Skip to content

Added composer.json and modman files#2

Merged
dweeves merged 1 commit intodweeves:masterfrom
avstudnitz:master
Oct 8, 2013
Merged

Added composer.json and modman files#2
dweeves merged 1 commit intodweeves:masterfrom
avstudnitz:master

Conversation

@avstudnitz
Copy link
Contributor

@dweeves
Copy link
Owner

dweeves commented Oct 7, 2013

HI Andreas,

I don't know composer. can you explain the goal of these files ?

@avstudnitz
Copy link
Contributor Author

Sure. The link I provided gives a good background on composer.
In short, Composer is used to put your magento installation together with modules from different sources. Those can be own modules or open source ones like yours. The module sources are downloaded automatically and symlinked into your magento directory into the right places. It's very useful if you want to keep the included modules up to date or if you are using your modules on several projects.
If you include those two files, everyone who is using composer will be able to include your module into his/her projects with (literally) two lines of code and keep it up to date.

dweeves added a commit that referenced this pull request Oct 8, 2013
Added composer.json and modman files
@dweeves dweeves merged commit ff6f779 into dweeves:master Oct 8, 2013
@avstudnitz
Copy link
Contributor Author

Thanks!

@joshribakoff
Copy link

Thanks for merging this

PatrickCronin added a commit to PatrickCronin/magmi-git that referenced this pull request Jul 30, 2014
This problem prevented me from performing a stock update using a fresh install of Magmi 0.7.19a on a fresh install of Magento CE 1.9.0.1. I created two simple products in Magento and tried to update their stock information them using Magmi. I created a two-column CSV ("sku" and "qty") and attempted to import it. I got the following errors:

1 SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'use_config_manage_stock' cannot be null -
2 SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'use_config_manage_stock' cannot be null - ERROR ON RECORD dweeves#1
3 SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'use_config_manage_stock' cannot be null -
4 SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'use_config_manage_stock' cannot be null - ERROR ON RECORD dweeves#2

More details on this error are here: https://sourceforge.net/p/magmi/discussion/1228365/thread/8e722889/

I tracked the problem to filterkvarr(). If the $kvarr has values which are numerical 0's, the function changes their values to null. This is because var_dump(0 == '__NULL__'); // 0 == 0 -> true. However, var_dump(0 === '__NULL__'); // 0 !== '__NULL__' -> false. So I suggest this change. (See PHP's documentation on this: http://us1.php.net/operators.comparison).
dweeves pushed a commit that referenced this pull request Jan 11, 2016
dweeves pushed a commit that referenced this pull request May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants