Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-fuzz-build fix: not-package dirs #311

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

go-fuzz-build fix: not-package dirs #311

wants to merge 9 commits into from

Commits on Feb 1, 2021

  1. Context.clonePackage() also copies non-package dirs

    @guzenok
    guzenok committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    e8d48c0 View commit details
    Browse the repository at this point in the history

  2. packageDir() returns local directory with package source files

    @guzenok
    guzenok committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    73feda7 View commit details
    Browse the repository at this point in the history

  3. isPackage() checks if dir contains go source files

    @guzenok
    guzenok committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    6bbc7c9 View commit details
    Browse the repository at this point in the history

  4. style fix

    @guzenok
    guzenok committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    6c0ebd4 View commit details
    Browse the repository at this point in the history

  5. join Context.copyNotPkgDir() and copyDir()

    @guzenok
    guzenok committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    c56131d View commit details
    Browse the repository at this point in the history

  6. style fix 

    "Using filepath.Dir(p.GoFiles[0]) inline, the way it was, is better. The comment that p.GoFiles is non-empty is useful and should stay, but it could be shortened."
    @guzenok
    guzenok committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    5ca9f07 View commit details
    Browse the repository at this point in the history

  7. style fix 

    "place isNotPackage() in main.go along with the rest, near where they are used"
    @guzenok
    guzenok committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    fe5a773 View commit details
    Browse the repository at this point in the history

  8. style fix 

    "Negatives are harder to read at call sites. I'd prefer isPackage"
    @guzenok
    guzenok committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    ce28dfd View commit details
    Browse the repository at this point in the history

  9. style fix 

    "This comment should read: ..."
    @guzenok
    guzenok committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    a8e90a2 View commit details
    Browse the repository at this point in the history