-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-fuzz-build fix: not-package dirs #311
Open
guzenok
wants to merge
9
commits into
dvyukov:master
Choose a base branch
from
guzenok:fix/cgo-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Feb 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e8d48c0 - Browse repository at this point
Copy the full SHA e8d48c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73feda7 - Browse repository at this point
Copy the full SHA 73feda7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bbc7c9 - Browse repository at this point
Copy the full SHA 6bbc7c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c0ebd4 - Browse repository at this point
Copy the full SHA 6c0ebd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c56131d - Browse repository at this point
Copy the full SHA c56131dView commit details -
"Using filepath.Dir(p.GoFiles[0]) inline, the way it was, is better. The comment that p.GoFiles is non-empty is useful and should stay, but it could be shortened."
Configuration menu - View commit details
-
Copy full SHA for 5ca9f07 - Browse repository at this point
Copy the full SHA 5ca9f07View commit details -
"place isNotPackage() in main.go along with the rest, near where they are used"
Configuration menu - View commit details
-
Copy full SHA for fe5a773 - Browse repository at this point
Copy the full SHA fe5a773View commit details -
"Negatives are harder to read at call sites. I'd prefer isPackage"
Configuration menu - View commit details
-
Copy full SHA for ce28dfd - Browse repository at this point
Copy the full SHA ce28dfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8e90a2 - Browse repository at this point
Copy the full SHA a8e90a2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.