#266 Added additional TFM

[thompson-tomo]

This adds net 6 as a TFM which has 0 explicit dependencies and to support further additional TFM'S conditional compilation has been reviewed/tweaked.

Closes #223
Closes #262
Closes #265
Closes #266

[dvsekhvalnov]

@thompson-tomo , looks good to me. Is it really fixing everything? )

Ok, i guess i need to see if it really compiles on .net46/.net47 as both test runners failed. May be just tests though, as they live in separate folder.

Will give it a try next week.

[thompson-tomo]

Of the 4 linked issues, yes it should be as they are all wanting dependencies either bumped, downgraded or sourced from the framework. With this change on the latest TFM all dependencies come from the framework like suggested in the issues.

[alexander-jesner-AP]

Could it be the case that the NETFRAMEWORK symbol is not defined?
See https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives where it says:

" Note:
For traditional, non-SDK-style projects, you have to manually configure the conditional compilation symbols for the different target frameworks in Visual Studio via the project's properties pages."

And for what I saw the csproj files for the old frameworks are still "classic" and the old symbols are defined directly there:

https://github.com/dvsekhvalnov/jose-jwt/blob/master/jose-jwt/jose-jwt.net46.csproj where it says

<DefineConstants>TRACE;DEBUG;NET461</DefineConstants>

[thompson-tomo]

@alexander-jesner-AP you are likely correct as I didn't realise that those csproj were being for the test project.

[dvsekhvalnov]

running more tests.. let's see

[dvsekhvalnov]

okay, seems tests are passing.
will run cross-compatibility tests with other libraries and get back to you guys.

[dvsekhvalnov]

So, compatibility wise looking good to me.

But @thompson-tomo, how do you test if it fixes dependencies? I still get System.Cryptography and System.Text.Json:9+ installed when bringing library in. May be doing something stupid though.

[thompson-tomo]

Is the project you are bringing the library in to targeting net 6 or higher? as that is where the change becomes visible.

If it helps open the package with https://nuget.info/ and check the dependencies tab as that will show the same info as nuget.org. If you would like share a screenshot of what you see.

[dvsekhvalnov]

Ah.. that's the catch. I guess tried on .net 5. Let me re-test with .net6+.

[thompson-tomo]

That would certainly do it.

[dvsekhvalnov]

yeah, .net8 looks good.

Okay, guess let's make it out then :)

v5.1.2 or v5.2 ?

[thompson-tomo]

Great. Make it 5.2