Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dispatch duplicated typing in index.d.ts #2250

Merged
merged 1 commit into from
Nov 21, 2019
Merged

fix: Dispatch duplicated typing in index.d.ts #2250

merged 1 commit into from
Nov 21, 2019

Conversation

xc1427
Copy link
Contributor

@xc1427 xc1427 commented Nov 21, 2019 •
edited
Loading

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Fix duplicated Dispatch import. TS 3.7 will report that as an error.

@coveralls
Copy link

coveralls commented Nov 21, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 86.461% when pulling d34eab1 on xc1427:cxi.fix.Dispatch_typing into 39067c0 on dvajs:master.

@xc1427 xc1427 force-pushed the cxi.fix.Dispatch_typing branch from 0507c6d to d34eab1 Compare November 21, 2019 11:27
@sorrycc sorrycc merged commit 819a021 into dvajs:master Nov 21, 2019
@xc1427 xc1427 deleted the cxi.fix.Dispatch_typing branch November 22, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr(bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xc1427 @coveralls @sorrycc