Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade react-router to 5 #2229

Closed
wants to merge 1 commit into from
Closed

feat: upgrade react-router to 5 #2229

wants to merge 1 commit into from

Conversation

chiaweilee
Copy link

@chiaweilee chiaweilee commented Oct 25, 2019 •
edited
Loading

Checklist
  • [ x ] npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines

@chiaweilee chiaweilee changed the title dep: update react-router-dom to avoid warning feat: upgrade react-router to 5 Oct 25, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.681% when pulling 69d516a on chiaweilee:patch-2 into 0e763de on dvajs:master.

@sorrycc
Copy link
Member

sorrycc commented Nov 18, 2019

It's done via #2241.

@sorrycc sorrycc closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiaweilee @coveralls @sorrycc