Fill out grid DDT from MPAS#7
Merged
dustinswales merged 10 commits intoJan 20, 2026
Merged
Conversation
Collaborator
Author
|
Next step is surface data... |
Collaborator
Author
|
I should probably remove the ccpp-physics hash update -- I am using a test branch that isn't meant to be shared. |
dustinswales
approved these changes
Jan 20, 2026
Owner
dustinswales
left a comment
There was a problem hiding this comment.
@grantfirl Thanks for these changes.
Gathering changes in my branch is fine for the time being.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Dustin,
I'm not sure if you want to periodically merge my work back in or what, but here are my first code changes if you do!
I'm going through the timestep_init phase of the RRFS_MPAS suite and found that there are a bunch of uninitialized variables in GFS_phys_time_vary, so that is where I'm getting my feet wet.
This code does the following:
I'm using
areaCellfrom MPAS for the area, which is straightforward enough. For dx, rather than sqrt(area) as is done for FV3, I found how it is calculated in the standalone MPAS GWD driver, using theconfig_len_dispMPAS configuration variable or thenominalMinDc, whichever is available. I copied this code from mpas_atm_core.F/atm_core_init() from the standalone.This compiles/runs.