Skip to content

Fill out grid DDT from MPAS#7

Merged
dustinswales merged 10 commits into
dustinswales:feature/mpas_lbc_plus_cleanupfrom
grantfirl:feature/mpas_lbc_plus_cleanup_gjf
Jan 20, 2026
Merged

Fill out grid DDT from MPAS#7
dustinswales merged 10 commits into
dustinswales:feature/mpas_lbc_plus_cleanupfrom
grantfirl:feature/mpas_lbc_plus_cleanup_gjf

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

Hey Dustin,

I'm not sure if you want to periodically merge my work back in or what, but here are my first code changes if you do!

I'm going through the timestep_init phase of the RRFS_MPAS suite and found that there are a bunch of uninitialized variables in GFS_phys_time_vary, so that is where I'm getting my feet wet.

This code does the following:

  • adds a new call during the atmos_model.F90/atmos_model_init() subroutine to call the newly-created atmos_coupling.F90/ufs_mpas_grid_to_physics() that accepts the newly created GFS_grid_type DDT.
  • atmos_coupling.F90/ufs_mpas_grid_to_physics() basically does the same thing as GFS_init.F90/grid_populate(); sets lat/lon in rad/deg, sinlat, coslat, area, and dx.

I'm using areaCell from MPAS for the area, which is straightforward enough. For dx, rather than sqrt(area) as is done for FV3, I found how it is calculated in the standalone MPAS GWD driver, using the config_len_disp MPAS configuration variable or the nominalMinDc, whichever is available. I copied this code from mpas_atm_core.F/atm_core_init() from the standalone.

This compiles/runs.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

Next step is surface data...

@grantfirl
Copy link
Copy Markdown
Collaborator Author

I should probably remove the ccpp-physics hash update -- I am using a test branch that isn't meant to be shared.

Copy link
Copy Markdown
Owner

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grantfirl Thanks for these changes.
Gathering changes in my branch is fine for the time being.

@dustinswales dustinswales merged commit d5e2c86 into dustinswales:feature/mpas_lbc_plus_cleanup Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants