-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alban/warroom cherry #11069
Open
albandum
wants to merge
15
commits into
main
Choose a base branch
from
alban/warroom-cherry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Alban/warroom cherry #11069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 554ad93 Author: Alban Dumouilla <[email protected]> Date: Tue Feb 25 14:59:17 2025 +0100 CarouselOK commit aa26509 Author: Henry Fontanier <[email protected]> Date: Tue Feb 25 12:10:15 2025 +0100 fix: role not granted error (#11052) Co-authored-by: Henry Fontanier <[email protected]> commit e24187c Author: Thomas Draier <[email protected]> Date: Tue Feb 25 12:07:55 2025 +0100 [front] Add global search (#11035) commit 37d940e Author: Jules Belveze <[email protected]> Date: Tue Feb 25 11:57:53 2025 +0100 [core] - refacto: add new node types for grouped resources (#11029) * [core] - feature: add new node types for grouped resources - Introduced `Tables` and `Documents` node types to represent collective structures in the data source module - Implemented display formatting for the newly added node types * [core] - refactor: standardize NodeType enum variants and serialization - Renamed enum variants in NodeType to match singular form and standardized the display formatting - Added serialization aliases to NodeType to ensure consistency in serialized data forms * [core] - fix: correct typo in NodeType display implementation - Fixed misspelling of "folder" in the NodeType enum's Display trait implementation * [core] - refactor: standardize NodeType enum serialization - Change NodeType enum variant annotations to lowercase in serde rename - Add `Document`, `Table`, and `Folder` as serde aliases for the NodeType variants * [core] - refactor: adjust serialization and search filter for node types - Remove explicit serialization attributes for NodeType variants to derive default behavior - Enhance search filter to consider both original and lowercase versions of node types * [core] - feature: implement custom serialization for NodeType enum - Add support for case-insensitive serialization and deserialization of NodeType values [front] - fix: align icon selection with updated NodeType casing - Handle lowercase node types when assigning icons in the UI layer [types] - refactor: update ContentNodeType to include lowercase variants - Extend ContentNodeType typing to accept both uppercase and lowercase variants * [front/components] - fix: standardize node type comparison to be case-insensitive - Adjust various comparisons of node types to include lowercase equivalents for 'Document', 'Table', and 'Folder' - Ensure functionality such as view filtering and permission handling remains consistent regardless of node type casing * fix: lint/format --------- Co-authored-by: Flavien David <[email protected]> commit 20c87f7 Author: Flavien David <[email protected]> Date: Tue Feb 25 11:49:57 2025 +0100 Data source name is optional (#11051) commit 9437d5c Author: Sebastien Flory <[email protected]> Date: Tue Feb 25 11:19:05 2025 +0100 Fix: do not import pegjs file all the time (#11050) commit b088ab5 Author: Jules Belveze <[email protected]> Date: Tue Feb 25 11:16:48 2025 +0100 [front] - enhance(builder): KS (#11048) * [data_source_view] - refactor: streamline parent title and provider display in DataSourceViewsSelector - Refactor the display of an item's parent title and connector provider to show in a single span with conditional rendering based on provider availability - Remove unnecessary div element for encapsulating the provider logo component * [front] - feature: enhance DataSourceViewSelector UX - Truncate long titles in the DataSourceViewSelector to prevent overflow - Display connector provider name and parent title with better layout adjustments - Improve navigation by auto-scrolling to the selected item in the search result - Import `useRef` hook in the DataSourceViewSelector component for reference management * [front] - refactor: streamline imports in DataSourceViewSelector - Remove unused individual imports and use type-only import for React methods * [front] - feature: update @dust-tt/sparkle to version 0.2.416 - Bump the version of @dust-tt/sparkle to incorporate the latest features and fixes - Ensure compatibility with other dependencies within the project * [front] - fix: adjust margins for tag and data source view items - Add left and right margins to enhance spacing and visual separation between items in the list views - Make UI more consistent and visually appealing by adjusting item margins in both TagSearchInput and DataSourceViewsSelector components * [front/components] - feature: improve search result visibility in content node tree - Added an id to tree items to enable search result highlighting - Implemented automatic scrolling to the search result node for better user experience [front/data_source_view] - refactor: streamline search result focus handling - Removed unnecessary useRef and associated effect for search result focus - Centralized search result scrolling behavior within DataSourceViewsSelector useEffect [front] - devops: update @dust-tt/sparkle package to version 0.2.417 - Package version bump to incorporate new features or fixes in the dependency * [front] - fix: adjust open condition for DataSourceView search dropdown - Change the conditional for opening the search dropdown to check for minimum query size instead of search results and text presence * [data_source_view] - feature: implement loading indicator for search functionality - Integrated a loading state feedback into the DataSourceViewsSelector when performing search operations - Updated the @dust-tt/sparkle library to version 0.2.418 commit 4875372 Author: Alexandre Pinot <[email protected]> Date: Tue Feb 25 11:14:01 2025 +0100 Landing Page visuals edit (#11049) * landing nit * updated futuresectionpage * lint commit 6b8c311 Author: Jules Belveze <[email protected]> Date: Tue Feb 25 10:41:43 2025 +0100 [sparkle] - enh(`SearchInputWithPopover`): add isLoading state (#11046) * [sparkle] - feature: add loading state to search input component - Implement a spinner to indicate loading when search results are being fetched - Provide better feedback to users by displaying a loading state in the search popover * [sparkle] - feature: upgrade @dust-tt/sparkle to version 0.2.418 - Increment the package version to release new features or fixes commit b307b04 Author: Jules Belveze <[email protected]> Date: Tue Feb 25 09:55:08 2025 +0100 [sparkle] - chore(Tree): pass id to `Tree.Item` (#11045) * [sparkle] - feature: add id prop to Tree.Item component - Allow attaching a unique identifier to each Tree.Item for improved accessibility and testing purposes - Ensure the id gets rendered into the DOM for reference and styling if provided * [sparkle] - feature: bump version to 0.2.417 - Version update includes the latest features, bug fixes, and performance improvements. commit 5242646 Author: Flavien David <[email protected]> Date: Tue Feb 25 09:54:47 2025 +0100 Add data source index support and fix search analyzer issues (#11039) * tmp * E2E * ✂️ * Add PATCH mappings * ✨ * 📖 * ⬇️ * Remove useless fields * Add node_id in parents array. * Address comments from review commit e4eec65 Author: Aubin <[email protected]> Date: Tue Feb 25 09:30:05 2025 +0100 fix(Slack) - Update channel timestamps (#11036) * add a function updateSlackChannelInCoreDb * add Slack channels data_sources_folders upserts to update the timestamp * bump workflow queue version commit 46de96c Author: Aubin <[email protected]> Date: Tue Feb 25 08:56:23 2025 +0100 Improve handling of diff between tags.title and title (#11042) * ignore diff in titles due to prefixes * Revert "ignore diff in titles due to prefixes" This reverts commit 6f7e803. * replace error with warn, remove todo * remove the patch added to correctly display untitled nodes * Revert "remove the patch added to correctly display untitled nodes" This reverts commit 3539411. commit b90e5fe Author: Jules Belveze <[email protected]> Date: Tue Feb 25 08:44:59 2025 +0100 [sparkle] - chore: tweaks for KS (#11044) * [sparkle] - feature: make search popover stretch to full width - Search popover now expands to use the full width of its container for better visibility of search results and enhanced UI appearance * [sparkle] - refactor: wrap Tree.Item in React.forwardRef - Enable Tree.Item to accept ref props by wrapping it with React.forwardRef - Maintain the existing TreeItemProps type compatibility while integrating forward refs capability * [sparkle] - feature: bump package version to 0.2.416 - Package version updated from 0.2.415 to 0.2.416 to introduce new features or fixes commit 77d9491 Author: Jules Belveze <[email protected]> Date: Tue Feb 25 08:12:49 2025 +0100 [front] - fix: prevent default action on save button click in modal (#11030) - Added `event.preventDefault()` to stop the default form submission when clicking the "Save" button - Ensures onSave logic is executed without page reload or navigation interference commit 2715d32 Author: Henry Fontanier <[email protected]> Date: Mon Feb 24 23:20:56 2025 +0100 use correct min generation tokens for model (#11043) Co-authored-by: Henry Fontanier <[email protected]> commit 36f8455 Author: Henry Fontanier <[email protected]> Date: Mon Feb 24 20:08:00 2025 +0100 feat: add claude 3.7 sonnet (#11041) Co-authored-by: Henry Fontanier <[email protected]> commit 7e8454b Author: Thomas Draier <[email protected]> Date: Mon Feb 24 18:48:34 2025 +0100 [front] Export and import core apps (#11008) * Export and import core apps * simplified, export all specs * cleaned * comment * fix * clean * skip already imported apps * Add action to restore app * fixed merge * review comments * import * removed plugin * cleaned * missing file commit 6c923cc Author: Henry Fontanier <[email protected]> Date: Mon Feb 24 18:32:39 2025 +0100 enh: add rust coding rule (#11040) Co-authored-by: Henry Fontanier <[email protected]> commit 8e58ac2 Author: Henry Fontanier <[email protected]> Date: Mon Feb 24 18:07:24 2025 +0100 fix(notion): use all multi-select properties as custom tags (#11038) Co-authored-by: Henry Fontanier <[email protected]> commit 1beeff1 Author: Aubin <[email protected]> Date: Mon Feb 24 18:04:07 2025 +0100 fix(Slack) - Fix missing upsert on Slack new channels (#11032) * refactor a use of SlackConfigurationModel to use the Resource * add a missing upsertDataSourceFolder commit c9b9155 Author: Aubin <[email protected]> Date: Mon Feb 24 17:59:21 2025 +0100 enh(core) - Add the hit count to `/nodes/search` endpoint (#11027) * add a track_total_hits * update the ES query to return the hit count + update the return body * update the type in core_api commit 3cf3f1a Author: Henry Fontanier <[email protected]> Date: Mon Feb 24 17:14:21 2025 +0100 fix: client side exception when editing dust global agent (#11034) Co-authored-by: Henry Fontanier <[email protected]> commit d97c1d5 Author: Henry Fontanier <[email protected]> Date: Mon Feb 24 17:02:19 2025 +0100 fix: batch add (#11033) Co-authored-by: Henry Fontanier <[email protected]> commit a5c5ba9 Author: Aubin <[email protected]> Date: Mon Feb 24 15:53:04 2025 +0100 include new tickets in the sync (#11031) commit 6b4c612 Author: Henry Fontanier <[email protected]> Date: Mon Feb 24 14:41:53 2025 +0100 fix: support inherited DB role in snowflake (2) (#11028) Co-authored-by: Henry Fontanier <[email protected]> commit 8b397cd Author: Henry Fontanier <[email protected]> Date: Mon Feb 24 13:37:45 2025 +0100 fix: support inherited DB role in snowflake (#11026) Co-authored-by: Henry Fontanier <[email protected]> commit 5d9ef8e Author: Daphné Popin <[email protected]> Date: Mon Feb 24 11:54:39 2025 +0100 Salesforce temporal workflow (#11012) * Salesforce wip play with api * Get / Set permissions * Utils * Fix * Salesforce temporal workflow * Set it every 30 min to start with * Remove debug commit a5cfaa4 Author: Jules Belveze <[email protected]> Date: Mon Feb 24 11:51:32 2025 +0100 [front] - chore(space): prettify datatable (#11024) * [front/components/spaces] - refactor: streamline imports and adjust date format in SpaceDataSourceViewContentList - Consolidate multiple import statements from "@dust-tt/types" and "@tanstack/react-table" into single lines for readability - Change the width class of 'lastUpdatedAt' column from 'w-48' to 'w-20' - Align the date content to the right for 'lastUpdatedAt' column - Add a new 'compact' date format option for timestamps and use it in 'lastUpdatedAt' column * [front/components/spaces] - refactor: clean up and enhance table column UI in ContentList - Remove unnecessary import of MenuItem type, as it's already included elsewhere - Reorganize imports for readability and consistency across components - Update the "Available to" table column to include a header with aligned text - Revise formatting utility to allow consistent date presentation in compact view * [data_source_view] - refactor: streamline DataSourceViewSelector imports and UI adjustment - Consolidate imports for better readability and to follow code style guidelines - Update parent title display format in DataSourceViewsSelector component for visual consistency * fix: lint/format * [front] - fix: update date format to include year in timestamp - Changed the date formatting to show a 2-digit year instead of the day of the month in friendly date representations commit 212bda9 Author: Aubin <[email protected]> Date: Mon Feb 24 11:34:53 2025 +0100 feat(Zendesk) - Allow syncing unresolved tickets (#10991) * add a ZendeskConfigView * uniformize error messages * add column syncUnresolvedTickets to ZendeskConfiguration model * add migration script * add get/set configuration key methods * choose tickets to sync based on configuration * improve copy * fix icon * whitelist the new config key * add disclaimer commit ed9f055 Author: Alban Dumouilla <[email protected]> Date: Mon Feb 24 11:09:24 2025 +0100 drive.meet.readonly scope full release (#11022) commit 6a3cec6 Author: Jules Belveze <[email protected]> Date: Mon Feb 24 10:54:20 2025 +0100 [front] - chore: add parent name in builder search (#11023) * [types] - feature: add optional parentTitle to DataSourceViewContentNode - Include the title of the parent node in DataSourceViewContentNode for better context understanding * [front/components/data_source_view] - feature: display parent titles in data source view selector - Include parent title information alongside each item in the data source view selector - Log the search result nodes to console for debugging purposes - Ensure parent titles are fetched properly by extending the `getContentNodeFromCoreNode` function in the API layer * fix: lint/format commit 4c61494 Author: Daphné Popin <[email protected]> Date: Mon Feb 24 10:37:11 2025 +0100 Salesforce: Connector permissions (#11002) * Salesforce wip play with api * Get / Set permissions * Utils * Fix commit ff36f6c Author: Flavien David <[email protected]> Date: Mon Feb 24 10:12:09 2025 +0100 Add proper support for Markdown in InputBar (#11005) * Add proper support for Markdown in InputBar * ✨ * Update useCustomEditor.tsx * 👕 * Bump Sparkle version * ✨ commit 4a785ba Author: Flavien David <[email protected]> Date: Mon Feb 24 09:37:53 2025 +0100 Bump Sparkle (#11020) commit 947063c Author: Henry Fontanier <[email protected]> Date: Sun Feb 23 14:59:51 2025 +0100 enh: add coding rule related to function parameters mutation (#11011) Co-authored-by: Henry Fontanier <[email protected]> commit 3928788 Author: Stanislas Polu <[email protected]> Date: Sat Feb 22 22:35:11 2025 +0100 remove retries from upsertDataSourceTableFromCsv commit 571e819 Author: Stanislas Polu <[email protected]> Date: Sat Feb 22 22:34:04 2025 +0100 Revert "remove retry" This reverts commit fa4adac. commit 1f69b58 Author: Stanislas Polu <[email protected]> Date: Sat Feb 22 22:34:04 2025 +0100 Revert "lint" This reverts commit 108bf28. commit 108bf28 Author: Stanislas Polu <[email protected]> Date: Sat Feb 22 22:11:45 2025 +0100 lint commit fa4adac Author: Stanislas Polu <[email protected]> Date: Sat Feb 22 21:59:52 2025 +0100 remove retry commit 2e48aa7 Author: Henry Fontanier <[email protected]> Date: Sat Feb 22 15:24:12 2025 +0100 fix: remove unwrap in float parsing (#11015) Co-authored-by: Henry Fontanier <[email protected]> commit 9c55862 Author: Stanislas Polu <[email protected]> Date: Sat Feb 22 07:37:42 2025 +0100 connector: table upsert log and retry commit 75edece Author: Stanislas Polu <[email protected]> Date: Fri Feb 21 20:48:02 2025 +0100 improve core - front - connectors invalid CSV errors commit 133b585 Author: Stanislas Polu <[email protected]> Date: Fri Feb 21 18:09:46 2025 +0100 fix tests commit 2773208 Author: Stanislas Polu <[email protected]> Date: Fri Feb 21 13:16:41 2025 +0100 bucket and review fix commit 30a596c Author: Stanislas Polu <[email protected]> Date: Thu Feb 20 17:57:12 2025 +0100 fix accepted use-cases commit 21f929a Author: Stanislas Polu <[email protected]> Date: Thu Feb 20 14:42:52 2025 +0100 Remove unused csv content path WIP remove CSV remove raw CSV remove csv content flow fix tests commit d3fd3d7 Author: Jules Belveze <[email protected]> Date: Fri Feb 21 17:22:23 2025 +0100 [front] - feat(SearchInputWithPopover): press "Enter" (#11010) * [front] - feature: enhance search result selection behavior in DataSourceView - Implement onItemSelect function to update the search result and reset the search text when an item is selected - Modify list item styling to include rounded corners on hover for better visual feedback * [front] - feature: upgrade @dust-tt/sparkle to version 0.2.414 - Update package to include the latest features and fixes from the @dust-tt/sparkle library - Ensure compatibility with updated dependencies and resolved integrity hashes in package-lock.json * [front] - refactor: update TagSearchInput to use div with onClick - Replaced Button with div for rendering tag items and handling selection - Ensured the input field is cleared after a tag is selected commit 7bb5b45 Author: Flavien David <[email protected]> Date: Fri Feb 21 17:18:50 2025 +0100 Flav/sparkle markdown variants (#10999) * Export Markdown styles * Bump Sparkle version * Address comments from review * 🎨 * ✂️ commit 147708c Author: Henry Fontanier <[email protected]> Date: Fri Feb 21 17:18:06 2025 +0100 fix: display snowflake errors instead of closing modal (#11009) Co-authored-by: Henry Fontanier <[email protected]> commit a783cfa Author: Jules Belveze <[email protected]> Date: Fri Feb 21 16:39:47 2025 +0100 [front] - feat(builder): search ds (#11003) * [front/components/data_source_view] - feature: integrate search functionality in DataSourceViewsSelector - Added new search input with popover to filter DataSourceView content nodes based on search terms - Provided visual cues for content node types using dedicated icons in search results - Adjusted DataSourceViewSelector to respond to search results and expand appropriate trees - Implemented feature flag conditional logic for enabling search feature [front/lib/swr] - refactor: add disabled flag support for useSpaceSearch hook - Introduced a 'disabled' parameter for the useSpaceSearch hook to conditionally enable or disable search functionality * [data_source_view] - refactor: streamline DataSourceViewSelector code and fix collapse logic - Removed unnecessary wrapping divs around ContextItem for cleaner JSX structure - Adjusted logic to properly handle collapsing of the website section when a search result is selected - Cleared the search input upon selecting a search result for a better user experience - Simplified imports for better code readability * [front/components/data_source_view] - feature: enhance selection handling in DataSourceViewsSelector - Implement a new function to update selection configurations with nodes selected from search results - Ensure selected search results are added to the selection configurations state - Update onClick handler to enhance item selection process from search results - Refactor imports and code formatting for better readability and maintenance * [front/components/data_source_view] - fix: correct logic for search feature flag - Invert the boolean logic for the `searchFeatureFlag` to properly enable or disable the search feature - Wrap the `SearchInputWithPopover` component with a condition to only render when the `searchFeatureFlag` is true * [front] - refactor: adjust import order for feature flags hook - Standardize the positioning of the `useFeatureFlags` import statement within the file * [front] - refactor: optimize DataSourceViewSelector search logic - Removed unused constants and simplified content node type icons implementation - Implemented useEffect to debounce search text for improved search performance - Streamlined the search result handling by replacing `searchResults` with `searchResult` - Enhanced clarity and maintainability by cleaning up and naming functions and variables more appropriately * [front/components/data_source_view] - fix: toggle search feature flag logic and update search result item rendering - Correct the logic for the 'search_knowledge_builder' feature flag to properly enable or disable search features - Refactor the rendering of search result items for a better user experience and visual consistency * [front] - fix: correct search feature flag conditional check - Updated the condition to correctly determine if the "search_knowledge_builder" feature flag is included - Cleaned up imports by consolidating them into single lines, improving readability * fix: lint/format commit cfb66b4 Author: Jules Belveze <[email protected]> Date: Fri Feb 21 16:26:19 2025 +0100 [sparkle] - enh(SearchInputWithPopover): add enter callback (#11007) * [sparkle] - feature: implement item selection in SearchInput component - Add `onItemSelect` callback prop to handle item selection when user presses Enter - Ensure the selected item is passed to the `onItemSelect` handler when triggered - Improve readability by breaking down long lines and removing unnecessary whitespace * [sparkle] - feature: bump version to 0.2.414 - Increment package version for a new release - Ensure consistency across package.json and package-lock.json files commit 6e1bc31 Author: Aubin <[email protected]> Date: Fri Feb 21 15:58:35 2025 +0100 fix inputs to use sparkle's Input (#11006) commit 5163c8c Author: Sebastien Flory <[email protected]> Date: Fri Feb 21 15:03:32 2025 +0100 Bring back excel file uploads (#11004) commit 9c33bb3 Author: Aubin <[email protected]> Date: Fri Feb 21 14:10:50 2025 +0100 add dark mode to JsonViewer (#11001) commit 178b4a1 Author: Aubin <[email protected]> Date: Fri Feb 21 13:52:03 2025 +0100 Remove the "Untitled Document' default value when title tag is passed (#10992) * refactor: use substring(6) instead of split -> slice -> join * add a fileName tag for static datasource upserts, which may differ from the overridable title * add a fileName tag for static datasource table upserts, which may differ from the non-overridable title * fill the title with the ones in the tags * address comments commit 90e4868 Author: Stanislas Polu <[email protected]> Date: Fri Feb 21 12:23:22 2025 +0100 core: clean-up bakward compatible support for CSV buckets commit e3d80a0 Author: Jules Belveze <[email protected]> Date: Fri Feb 21 11:50:00 2025 +0100 [front/lib/api] - chore: pass `DataSourceView` in `getContentNodes` (#10998) * [front/lib/api] - refactor: pass DataSourceView information to getContentNodeFromCoreNode - Refactor getContentNodeFromCoreNode to accept an additional dataSourceView argument, providing more context - Update getContentNodesForDataSourceView to pass dataSourceView when mapping core nodes to content nodes [front/pages/api] - fix: ensure DataSourceView is available before transforming nodes - Implement a safety check to ensure a DataSourceView is present before converting search results to content nodes - Log an error if the DataSourceView lookup fails to prevent incomplete node transformations [types] - refactor: update ContentNode structure with dataSourceView and reorganize fields - Add dataSourceView property to ContentNode interface, associating nodes directly with their data source view - Reorder the fields in the ContentNode interface for consistency and clarity * [types] - refactor: reformat import statements in connectors_api.ts - Grouped related import statements from "../../connectors/admin/cli" for better readability and maintainability - Ensured consistency with project import statement styling conventions * [types] - refactor: update content node structure in data sources - Removed `dataSourceView` property from `ContentNode` in `connectors_api.ts` to avoid redundancy - Added `dataSourceView` property to `DataSourceViewContentNode` in `data_source_view.ts` for enhanced context * [data_source_view] - feature: include dataSourceView in selected nodes payload - Augmented the node payload with `dataSourceView` to provide additional context during selection * [front/lib/api] - refactor: update dataSourceView handling in getContentNodeFromCoreNode - Remove direct use of DataSourceViewResource in getContentNodeFromCoreNode, now only accepts DataSourceViewType - Update getContentNodesForDataSourceView to conditionally transform dataSourceView to JSON if it's an instance of DataSourceViewResource before passing to getContentNodeFromCoreNode [front/pages/api] - fix: ensure search API returns correctly formatted nodes - Modify search API handler to convert dataSourceView to JSON before passing to getContentNodeFromCoreNode for consistent node formatting commit 97df270 Author: Thomas Draier <[email protected]> Date: Fri Feb 21 10:54:03 2025 +0100 [front] Fix call when rendered in ssr (#10997) commit 28dfee4 Author: Thomas Draier <[email protected]> Date: Fri Feb 21 10:30:53 2025 +0100 [sparkle] Fix call when rendered in ssr (#10995) * Fix call when rendered in ssr * bump sparkle * use effect/state to set container * fix commit 065c55c Author: Philippe Rolet <[email protected]> Date: Fri Feb 21 10:17:37 2025 +0100 [Search KB] Downsize search results from 20 to 15 (#10996) Description --- 20 was too much, a bit overwhelming, requiring scroll, etc commit 245f0f9 Author: Alban Dumouilla <[email protected]> Date: Fri Feb 21 09:50:29 2025 +0100 Revert "Move limit up for group_concat and make sure limit is not applied for…" (#10994) This reverts commit e5af67d. PMRR commit ec980a2 Author: Jules Belveze <[email protected]> Date: Fri Feb 21 09:38:48 2025 +0100 [front] - enh(tags): allow arrows to navigate filter (#10993) * [assistant_builder/tags] - refactor: streamline tag search input component - Simplify the rendering logic by utilizing SearchInputWithPopover properties for handling no results and item rendering - Upgrade @dust-tt/sparkle to version 0.2.412-rc-1 for new component features and improvements * [front] - fix: update TagSearchInput selected state styles - Adjust text color of the selected tag in dark mode for better visibility - Ensure consistent border and background styles for selected tags across themes * [front] - fix: update @dust-tt/sparkle to stable version - Upgrade @dust-tt/sparkle from a release candidate to the stable 0.2.412 version - Ensure package-lock.json reflects the updated package version and integrity sha commit 1a41a18 Author: Jules Belveze <[email protected]> Date: Fri Feb 21 09:16:44 2025 +0100 [sparkle] - enh: SearchInputWithPopover usage (#10986) * [sparkle] - refactor: enhance SearchInputWithPopover with keyboard navigation - Replaced children prop with items and renderItem in SearchInputWithPopover for rendering list items - Introduced keyboard navigation with arrow keys and enter to improve accessibility - Added noResults prop to show a message when there are no matching search results - Wrapped component export in a forwardRef implementing generic typing to maintain ref compatibility - Updated story to use new items and renderItem props for SearchInputWithPopover component * [sparkle] - feature: bump package version to 0.2.412 - Update `@dust-tt/sparkle` version in package.json and package-lock.json to reflect new changes in the codebase * [sparkle] - fix: handle optional noResults text in SearchInput component - Allow noResults prop to be optional by assigning an empty string as default when it is undefined - Adjust styling to ensure consistent display even when noResults message is not provided * Update sparkle/src/stories/SearchInput.stories.tsx Co-authored-by: Thomas Draier <[email protected]> --------- Co-authored-by: Thomas Draier <[email protected]> commit 299b980 Author: Stanislas Polu <[email protected]> Date: Thu Feb 20 21:49:08 2025 +0100 fix commit 39e5c5e Author: Stanislas Polu <[email protected]> Date: Thu Feb 20 18:23:01 2025 +0100 front: use the new bucket/bucket_csv_path format commit 0187aea Author: Stanislas Polu <[email protected]> Date: Thu Feb 20 18:10:09 2025 +0100 core: dual support for custom bucket and specific one commit c99b05f Author: Daphné Popin <[email protected]> Date: Thu Feb 20 20:05:33 2025 +0100 Static ds labels modals (#10989) commit 1f31774 Author: Philippe Rolet <[email protected]> Date: Thu Feb 20 19:27:18 2025 +0100 [Knowledge] Reset search when navigating to a folder (#10990) Description --- Fixes issue below Risks --- low Deploy --- front commit 293484c Author: Aubin <[email protected]> Date: Thu Feb 20 18:37:03 2025 +0100 Add backfill script on nodes titles (#10985) * add nodes title backfill script * log all inconsistencies * handle case where the title contains "title:" commit d84aa00 Author: Aubin <[email protected]> Date: Thu Feb 20 18:18:27 2025 +0100 fix (#10987) commit e5af67d Author: Alban Dumouilla <[email protected]> Date: Thu Feb 20 17:57:58 2025 +0100 Move limit up for group_concat and make sure limit is not applied for counts (#10984) * Move limit up for group_concat and make sure limit is not applied for counts * Hash update commit 8802cc0 Author: Henry Fontanier <[email protected]> Date: Thu Feb 20 17:46:07 2025 +0100 fix: ignrore missing crawlers (#10983) Co-authored-by: Henry Fontanier <[email protected]> commit b4b271e Author: Stanislas Polu <[email protected]> Date: Thu Feb 20 17:26:20 2025 +0100 core: [csv] better support for booleans commit 4c5b0cf Author: Henry Fontanier <[email protected]> Date: Thu Feb 20 17:28:43 2025 +0100 enh: improve xp for having same crawler in diff spaces (#10978) Co-authored-by: Henry Fontanier <[email protected]> commit 9d7ee5c Author: Aubin <[email protected]> Date: Thu Feb 20 17:09:27 2025 +0100 fix(Zendesk) - Ignore 404 on Zendesk article diff fetch (#10979) * fix a potential bug if 2 categories with the same ID are synced throughout 2 different brands in one setPermissions * ignore 404 * add a warn commit 700c156 Author: Philippe Rolet <[email protected]> Date: Thu Feb 20 16:57:07 2025 +0100 [Search-KB] Use keyword search in knowledge (behind FF) (#10972) * [Search-KB] Use keyword search in knowledge (behind FF) Description --- Fixes dust-tt/tasks#2211 - creates a search endpoint in spaces (given a space id), to do keyword search - add a feature flag "search_keyboard_builder" - add SWR and code to use keyword search in knowledge (in datasource) - after at least 3 chars are typed - debounced 300ms Risks --- Low, gated behind ff Deploy --- front * lint * added limit * show when no results + appropriately show spinner * don't show no results when typing * review * clean * clean 2 commit 0980bcb Author: Stanislas Polu <[email protected]> Date: Thu Feb 20 16:47:11 2025 +0100 front: improve logs to ease introspection of files that mismathc commit 18a45ea Author: Thomas Draier <[email protected]> Date: Thu Feb 20 16:45:25 2025 +0100 [connectors] Disable ocr in connectors (#10976) * Disable ocr in connectors * add timeout * ✨ * Log Text Extraction error * ✨ --------- Co-authored-by: Flavien David <[email protected]> commit e2f5b6c Author: Thomas Draier <[email protected]> Date: Thu Feb 20 16:42:42 2025 +0100 [front] Auto-expand tree on search result (#10973) * Auto-expand tree on search result * restore default * restore default commit 6c1781b Author: Stanislas Polu <[email protected]> Date: Thu Feb 20 16:08:24 2025 +0100 core: fixes to csv parsing commit dc7225e Author: Jules Belveze <[email protected]> Date: Thu Feb 20 16:05:45 2025 +0100 [front] - refacto: DataSourceViewsSelector (#10970) * [front/components/data_source_view] - feature: implement data source view space selector component - Adds a new component DataSourceViewsSpaceSelector for selecting data source views within specified spaces - Utilizes SpaceSelector component to filter data source views based on the selected space - Integrates loading state handling with a Spinner component while spaces are being fetched * [assistant_builder] - refactor: replace DataSourceViewsSelector with DataSourceViewsSpaceSelector - Adjusted AssistantBuilderDataSourceModal to use the new DataSourceViewsSpaceSelector component - Removed unused imports and simplified the DataSourceViewsSelector component logic [trackers] - refactor: update TrackerBuilderDataSourceModal to use DataSourceViewsSpaceSelector - Changed TrackerBuilderDataSourceModal to utilize DataSourceViewsSpaceSelector for consistent selector behavior [transcripts] - refactor: integrate DataSourceViewsSpaceSelector into LabsTranscriptsIndex - Replaced DataSourceViewsSelector with DataSourceViewsSpaceSelector in transcript processing module to align with other components - Ensured selection configurations and spaces are passed correctly to the new selector component [data_source_view] - refactor: streamline DataSourceViewsSelector and remove unnecessary loading spinner - Cleaned up DataSourceViewsSelector by removing conditional space rendering logic and loading spinner - Optimized usage of hooks and imports within the DataSourceViewsSelector component * [front] - feature: filter spaces to include only those with data source views - Add filtering of spaces to show only those that are associated with the current data source views - Handle the special case where there's only one space by directly showing its data source views selector * fix: lint/format commit 6d562cd Author: Henry Fontanier <[email protected]> Date: Thu Feb 20 16:01:53 2025 +0100 enh: show row count cap indicate in space content list (#10968) Co-authored-by: Henry Fontanier <[email protected]> commit 440e800 Author: Aubin <[email protected]> Date: Thu Feb 20 16:00:37 2025 +0100 fix call to /me with a brandSubdomain instead of a subdomain (#10974) commit a54c317 Author: Daphné Popin <[email protected]> Date: Thu Feb 20 15:28:54 2025 +0100 Revoke user: Launch workflow before tracking membership and log error (#10971) * Revoke user: Launch workflow before tracking membership and log error * Revoke user: Launch workflow before tracking membership and log error * Handle new case on poké tool * Fix rate limit * panic --------- Co-authored-by: Flavien David <[email protected]> commit 4b0879a Author: Thomas Draier <[email protected]> Date: Thu Feb 20 15:03:49 2025 +0100 [front] Outline feedback buttons (#10969) commit 9129b66 Author: Stanislas Polu <[email protected]> Date: Thu Feb 20 14:42:52 2025 +0100 Remove unused csv content path commit 534b0ad Author: Thomas Draier <[email protected]> Date: Thu Feb 20 14:36:15 2025 +0100 [front] Show buttons on hover (#10961) commit 46782e5 Author: Henry Fontanier <[email protected]> Date: Thu Feb 20 14:28:58 2025 +0100 enh(sparkle): pagination row count cap (#10966) Co-authored-by: Henry Fontanier <[email protected]> commit 7034710 Author: Daphné Popin <[email protected]> Date: Thu Feb 20 14:20:38 2025 +0100 Poké Dark mode (#10964) * Poké Dark mode * Fixes commit 43ed4f4 Author: Henry Fontanier <[email protected]> Date: Thu Feb 20 13:58:16 2025 +0100 enh(snowflake): logs + don't mutate function arguments (#10963) Co-authored-by: Henry Fontanier <[email protected]> commit b1c04f8 Author: Aubin <[email protected]> Date: Thu Feb 20 13:58:08 2025 +0100 fix(Google Drive) - Fix catching of TablesError (#10965) * remove redundant try catch * fix commit a03630d Author: Aubin <[email protected]> Date: Thu Feb 20 13:24:48 2025 +0100 Add Poke workspace plugin to check seat count (#10950) * add Poke workspace plugin to check usage * shorten the description (does not fit on a regular screen) * update the message displayed * remove auth from checkSeatCountForWorkspace to allow reusing it * add script to check seat count * fix copy * add dry run * add more explicit typing Co-authored-by: Flavien David <[email protected]> * launch the usage-queue workflow instead of reenacting it * update the copy * lint * Update front/lib/api/poke/plugins/workspaces/check_seat_count.ts Co-authored-by: Flavien David <[email protected]> * remove redundant+inaccurate check --------- Co-authored-by: Flavien David <[email protected]> commit 1df94e5 Author: Daphné Popin <[email protected]> Date: Thu Feb 20 12:06:55 2025 +0100 Labels copy (#10962) commit c5df139 Author: Alexandre Pinot <[email protected]> Date: Thu Feb 20 12:01:31 2025 +0100 minor update (#10960) commit df67922 Author: Alban Dumouilla <[email protected]> Date: Thu Feb 20 11:55:59 2025 +0100 Remove animation on home video (#10958) * Remove animation on home video * lint commit 1956b4f Author: Aubin <[email protected]> Date: Thu Feb 20 11:47:28 2025 +0100 enh(Intercom) - Add Help Center node as parent of collections (#10954) * add Help Center sync * add the Help Center ID to the collections and articles (always since the node will always be displayed) commit a786cdf Author: Flavien David <[email protected]> Date: Thu Feb 20 11:37:42 2025 +0100 Remove retrieval document sorting (#10959) commit 0520bd9 Author: Thomas Draier <[email protected]> Date: Thu Feb 20 10:00:51 2025 +0100 [sparkle] Message buttons out of box, display on hover (#10957) commit 1c333b0 Author: Aubin <[email protected]> Date: Thu Feb 20 09:57:44 2025 +0100 enh(Confluence) - Remove skip on pages with empty content (#10948) * upsert pages even when they have an empty content * add a warn commit 1337c73 Author: Alban Dumouilla <[email protected]> Date: Thu Feb 20 09:37:15 2025 +0100 Update privacy policy link (#10955)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests
Risk
Deploy Plan