fix electron rebuild

durs · May 15, 2021 · ec3d098 · ec3d098
1 parent cded0dd
commit ec3d098
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "winax",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Windows COM bindings",
   "homepage": "https://github.com/durs/node-activex",
   "keywords": [

diff --git a/src/disp.cpp b/src/disp.cpp
@@ -549,7 +549,7 @@ void DispObject::NodeCreate(const FunctionCallbackInfo<Value> &args) {
 			isolate->ThrowException(InvalidArgumentsError(isolate));
 			return;
 		}
-#ifdef NODE_V8V8
+#if (NODE_MAJOR_VERSION >= 14)
 		std::shared_ptr<BackingStore> store = input->Buffer()->GetBackingStore();
 		void *data = store->Data();
 #else

diff --git a/src/stdafx.h b/src/stdafx.h
@@ -36,12 +36,5 @@
 using namespace v8;
 using namespace node;
 
-#if (V8_MAJOR_VERSION >= 7) 
-#define NODE_V8V7
-#if (V8_MAJOR_VERSION >= 8) 
-#define NODE_V8V8
-#endif
-#endif
-
 // Application defines
 //#define TEST_ADVISE