Adds integration tests for http api. #44
Conversation
|
@awoods et al: I'm wondering if we should abandon FedoraLdpTest since we now have coverage in FedoraLdpTestIT |
There was a problem hiding this comment.
This looks good, but the build fails:
https://gist.github.com/awoods/de0ce9d68b3745737d4f7eb809fb9f7c
| @@ -15,13 +15,21 @@ | |||
| private JerseyLambdaContainerHandler<AwsProxyRequest, AwsProxyResponse> handler; | |||
|
|
|||
| /** | |||
| * Initialise the request handler with the AWS Proxy | |||
| * Default Constructor | |||
| */ | |||
| public JerseyRequestHandler() { | |||
There was a problem hiding this comment.
Is the default constructor being used anywhere?
If not, we can probably remove it.
| return internalURI.equals(rootURI); | ||
| } | ||
|
|
||
| private Container createRoot(final URI internalRootURI) { |
There was a problem hiding this comment.
Since we are storing the rootURI, it may be safer to change this method to:
private Container createRoot() {
return getContainerService().findOrCreate(rootURI);
}
| final Container container = containerService.findOrCreate(objectURI); | ||
| final ContainerService containerService = getContainerService(); | ||
| final URI resourceUri = createFromPath(externalPath); | ||
| //check that resource exists: |
There was a problem hiding this comment.
This comment is helpful... but it has drifted two lines apart from the related source code.
|
|
||
| final URI newResourceUri = createFromPath(resourceUri.getPath() + slug); |
There was a problem hiding this comment.
Since the slug is optional, we should check for null. In the case that the slug is null, we need to generate a UUID for the new resource name.
In either case, the new resource should be: resourceUri.getPath() + / + newId
| final URI newResourceUri = createFromPath(resourceUri.getPath() + slug); | ||
| final Container container = containerService.findOrCreate(newResourceUri); | ||
| final Model model = ModelFactory.createDefaultModel(); | ||
| model.read(requestBodyStream, null, "TTL"); |
There was a problem hiding this comment.
We can limit the input RDF type to turtle for now, but we should be supporting a range of RDF serialization as done here: https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-http-api/src/main/java/org/fcrepo/http/api/ContentExposingResource.java#L660-L664
There was a problem hiding this comment.
@awoods : so no change here for now, yes?
There was a problem hiding this comment.
I am ok with no change for now. I will create a GitHub issue.
* Updates comments on JerseyRequestHandler constructor * Removes unused ApiGatewayResponse and Response classes * Adds support for null slugs (and adds a new integration test to test said support)
No description provided.