Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to add Webpack Encore #425

Closed
wants to merge 12 commits into from

Conversation

packagespace
Copy link

Cont. #186

As explained in the last thread, this config works in a local env with HMR and in prod. No problem with Symfony UX packages either. Added a few improvements to avoid reinstalling node modules at every change in the source code.

I was wondering if there is a way this could be handled by a flex recipe, but if the only additions in the Dockerfile have to be made in the app_php image I'm not sure how it could be done.

Some extra notes in case it could help anyone tackle this / improve my approach:

  • Build output must be copied to both php image for entrypoints.json and caddy image for assets serving
  • Node container for dev environment does not need to be built from symfony_node image except for purposes of keeping the same node version
  • Some of the encore options might be deprecated (see Revert removing public option symfony/webpack-encore#1095)

@jmarcone
Copy link

Hi , I tried to use your solution , but I can't build the docker image:

image

Do you have an idea of what may be happening?

Thanks!

@ziat1988
Copy link

Hello,
Any update from this PR? I'm trying integrate Symfony UX and don't know how to do it correctly . The repo don't include nodejs container or any document related

@clemcoder
Copy link

I'm in the same situation. Do you have any idea when the addition of the asset build will be integrated into the main branch? Thanks.

@cptwtf
Copy link

cptwtf commented Sep 27, 2023

Also failing to get this to work with the current state of the repo.
Anyone who can provide some help?

@astronati
Copy link

astronati commented Oct 20, 2023

Any news about this enhancement @packagespace ? THANKS

@zpi12lmm
Copy link

If you are looking for a simple and quick solution, you can do it as follows: #497

@maxhelias
Copy link
Collaborator

maxhelias commented Dec 3, 2023

The reworking of the project for FrankenPHP calls this integration into question.

What's more, with the new AssetMapper component, it might be more interesting to concentrate on it.

Thank you for your contribution in spite of everything. And if anyone would like to try with AssetMapper, a PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants