cleanup: simplify the RPC concurrency configuration #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was confusing, the RPC-CONCURRENCY was configuring the number of parallel blocks we could ingest, instead of the real jsonRPC concurrency to the RPC node. This (in a backwards compatible way) makes the variable configure the jsonRPC max concurrency. The default value changed from: 25 to 80 to account for this. Number of concurrent workers to fetch blocks is now configured internally to: RPC_CONCURRENCY / 4.
msf
changed the title
adammilnesmith
approved these changes
Jul 30, 2024
Comment on lines
+52
to
+57
| ### Tuning for throughput | ||
| Throughput depends on: latency & request rate between RPC <-> Node Indexer <--> DuneAPI and can be tuned via a combination of: | ||
| 1. RPC_CONCURRENCY, higher values feed more blocks into the node indexer to process | ||
| 1. MAX_BATCH_SIZE, higher values send more blocks per request to DuneAPI | ||
| 1. BLOCK_SUBMIT_INTERVAL, the interval at which blocks to DuneAPI | ||
| See `--help` for up to date default values. |
There was a problem hiding this comment.
I like this section!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was confusing, the RPC-CONCURRENCY was configuring the number of parallel blocks we could ingest, instead of the real jsonRPC concurrency to the RPC node. It also didn't match what we had in our documentation (the README)
This change (in a backwards compatible way) makes the variable configure the jsonRPC max concurrency. The default value changed from: 25 to 80 to account for this.
It also updates the documentation.
Number of concurrent workers to fetch blocks is now configured internally to: RPC_CONCURRENCY / 4.