Scaffolding to support Arbitrum Nitro EVM stacks. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preparatory work to support Arbitrum Nitro RPC nodes
| // TODO: this method should be optional | ||
| // 2. call to eth_getTransactionReceipt for each Tx present in the Block | ||
| // | ||
| // We encode the payload in NDJSON, and use a header line to indicate how many Tx are present in the block |
There was a problem hiding this comment.
Is the last comment line relevant to the jsonrpc client? I thought this was relevant to the duneapi client
There was a problem hiding this comment.
I'll update the comment, I'm not sure I need this header per block message
adammilnesmith
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparatory work to support Arbitrum Nitro RPC nodes