Resume with blockchain progress endpoints #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vegarsti
force-pushed
the
progress-report
branch
from
e3cd9d3
to
b8c6063
Compare
vegarsti
force-pushed
the
use-blockchain-progress
branch
2 times, most recently
from
37cf797
to
a2d65bf
Compare
vegarsti
force-pushed
the
progress-report
branch
2 times, most recently
from
6fc3ab3
to
d28f60a
Compare
vegarsti
force-pushed
the
use-blockchain-progress
branch
from
a2d65bf
to
499a9ef
Compare
vegarsti
changed the title
vegarsti
force-pushed
the
use-blockchain-progress
branch
from
499a9ef
to
9b7e374
Compare
vegarsti
force-pushed
the
progress-report
branch
from
d28f60a
to
bf48eec
Compare
vegarsti
force-pushed
the
use-blockchain-progress
branch
2 times, most recently
from
7c5672e
to
5b1d3c5
Compare
vegarsti
commented
Jun 12, 2024
ingester/mainloop.go
Outdated
Comment on lines
106
to
113
| return ctx.Err() | ||
| return nil |
There was a problem hiding this comment.
It's not an error if the context is canceled
There was a problem hiding this comment.
but we rely on this to stop the other threads I think
vegarsti
commented
Jun 12, 2024
vegarsti
commented
Jun 12, 2024
vegarsti
force-pushed
the
use-blockchain-progress
branch
from
5b1d3c5
to
d826fa4
Compare
vegarsti
commented
Jun 12, 2024
vegarsti
added a commit
that referenced
this pull request
Jun 12, 2024
This PR adds Get and Post methods for the progress report API (duneanalytics/duneapi#559). We use the endpoints in #17 (and they work!). Towards CHAIN-1588.
vegarsti
force-pushed
the
use-blockchain-progress
branch
from
d826fa4
to
e3bbdc6
Compare
vegarsti
changed the title
msf
reviewed
Jun 12, 2024
ingester/mainloop.go
Outdated
| if err != nil { | ||
| return errors.Errorf("failed to get latest block number: %w", err) | ||
| } | ||
| progress, err := i.dune.GetProgressReport(ctx) |
There was a problem hiding this comment.
why not:
if startBlockNumber < 0 {
progress, err := i.dune.GetProgressReport(ctx)
...
startBlockNumber = progressReport.LastIngestedBlockNumber + 1
}
There was a problem hiding this comment.
aha yes, that's a good idea
ingester/mainloop.go
Outdated
Comment on lines
106
to
113
| return ctx.Err() | ||
| return nil |
There was a problem hiding this comment.
but we rely on this to stop the other threads I think
vegarsti
force-pushed
the
use-blockchain-progress
branch
from
e3bbdc6
to
e7ff6cd
Compare
vegarsti
force-pushed
the
use-blockchain-progress
branch
2 times, most recently
from
912364b
to
d16a777
Compare
vegarsti
force-pushed
the
use-blockchain-progress
branch
from
d16a777
to
353391b
Compare
|
Whew, time for a coffee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds use of the GetBlockchainProgress endpoint on startup, and continuous calls to PostProgressEndpoint to update the progress.
Try with
Towards CHAIN-1588.