Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few issues to make the main loop work #10

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix a few issues to make the main loop work #10

merged 1 commit into from
Jun 7, 2024

Conversation

vegarsti
Copy link
Member

@vegarsti vegarsti commented Jun 7, 2024

  • Removes the retryable http client for now. It's getting stuck retrying forever if there's an error (at least an internal error) and seems to ignore context cancel
  • Remove extra newlines in the payload
  • Fix trace request (we were adding an extra layer of string escaping)

@vegarsti vegarsti requested review from msf and helanto and removed request for msf June 7, 2024 07:50
Copy link
Member Author

vegarsti commented Jun 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vegarsti and the rest of your teammates on Graphite Graphite

@vegarsti vegarsti merged commit 64c84fa into main Jun 7, 2024
1 check passed
@vegarsti vegarsti deleted the fixes branch June 7, 2024 07:51
vegarsti added a commit that referenced this pull request Jun 7, 2024
As mentioned in #10, we were not seeing context propagation work. Turns
out we just needed to create the request with the context correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant