Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
msf committed Aug 22, 2024
1 parent 6cbb646 commit bbf0ff6
Showing 1 changed file with 18 additions and 6 deletions.
24 changes: 18 additions & 6 deletions client/jsonrpc/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,18 +121,30 @@ func (c *rpcClient) GroupedJSONrpc(
args []any,
output *bytes.Buffer,
debugBlockNumber int64,
) {
c.execOnPoolInGroup(group, func() error {
err := c.getResponseBody(ctx, method, args, output)
if err != nil {
c.log.Error("Failed to get response for jsonRPC",
"blockNumber", debugBlockNumber,
"method", method,
"error", err,
)
}
return err
})
}

func (c *rpcClient) execOnPoolInGroup(
group *errgroup.Group,
function func() error,
) {
group.Go(func() error {
errCh := make(chan error, 1)
c.wrkPool.Submit(func() {
defer close(errCh)
err := c.getResponseBody(ctx, method, args, output)
err := function()
if err != nil {
c.log.Error("Failed to get response for jsonRPC",
"blockNumber", debugBlockNumber,
"method", method,
"error", err,
)
errCh <- err
} else {
errCh <- nil
Expand Down

0 comments on commit bbf0ff6

Please sign in to comment.