Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete minor unreachable code caused by log.Fatal #54

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly [email protected]

see https://go.dev/play/p/jlrIP76KOCf for example:

package main

import (
	"log"
	"testing"
)

func TestLastIndex(t *testing.T) {
	log.Fatalf("this line will print and exit")
	t.Errorf("this line can't print")
}

/* output:
=== RUN   TestLastIndex
2009/11/10 23:00:00 this line will print and exit

Program exited.
*/

@codecov-commenter
Copy link

Codecov Report

Merging #54 (79ec3b5) into main (337f08a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files          46       46           
  Lines        3627     3627           
=======================================
  Hits         3038     3038           
  Misses        393      393           
  Partials      196      196           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@duke-git duke-git merged commit fbf251d into duke-git:main Aug 10, 2022
@Abirdcfly Abirdcfly deleted the patch-1 branch September 11, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants