Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLEW: move lib detection inside the OpenGL check loop #33

Open
SupervisedThinking opened this issue Jan 20, 2021 · 7 comments
Open

GLEW: move lib detection inside the OpenGL check loop #33

SupervisedThinking opened this issue Jan 20, 2021 · 7 comments

Comments

@SupervisedThinking
Copy link

With this commit e6b88ad configure checks if libGLEW is present which depends on OpenGL. So if you try to compile the emulator on systems without OpenGL it will still fail even though --disable-opengl was set.

@SupervisedThinking
Copy link
Author

Well I would recommend to use https://github.com/dosbox-staging/dosbox-staging as drop in replacement 👍🏻

@duganchen
Copy link
Owner

I'm going to leave this open, as it's a valid issue, even though the honest answer is that the whole point of this fork is to provide more features to OpenGL systems and that I could care less about supporting non-OpenGL systems.

@SupervisedThinking
Copy link
Author

Well don't get me wrong & no offence but your fork is "superflous" at some point, just check out dosbox-staging & if you can better invest your time & effort to improve this already way superior project.

@duganchen
Copy link
Owner

FYI: I actually was offered a position on dosbox-staging at one point. dosbox-staging/dosbox-staging#217 (comment)

@SupervisedThinking
Copy link
Author

SupervisedThinking commented Mar 24, 2021

@dreamer No thank you.

Well then farewell goodbye adieu & have fun with your fork ^^

@dreamer
Copy link

dreamer commented Mar 24, 2021

@SupervisedThinking, there's no reason to drag out old discussions.

@duganchen's fork is quality work - I referenced it several times when investigating certain technical decisions, investigating features, etc - and I'm 100% sure I will do it again in the future.

@duganchen - if you will ever change your mind and will plan to work on DOSBox codebase again, my offer for joining forces in DOSBox Staging project still stands 😃. Regardless - thank you for the good work you did in the past and careful documentation - it was very helpful to me.

@SupervisedThinking
Copy link
Author

@dreamer it's not a discussion, I've used this fork back in the days but it wasn't actively maintained nor fixed for years now. When I updated my packages for latest LE10.0 I realised that the OpenGL detection is somewhat problematic but at the same time I found dosbox-staging which is superior and that's a matter of fact.

I didn't know @duganchen was already asked for collaboration and so I recommended to have a look at dosbox-staging instead of fixing the dated buildchain on a pretty much dead fork.

If he's not interested that's fine but I already moved on.

jdorigao added a commit to jdorigao/batocera.linux that referenced this issue Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants