Fix nil pointer dereference panic on TCP reqs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `Close()` closes the tpc socket, but the underlying lib is still expecting it to be open so it can [do some retry logic](https://github.com/miekg/dns/blob/5c48f3623a4b2f1465b8ccf4fe29b6eb3888ee07/server.go#L332-L356) We either need to call `response.Hijack()` early – to let the underlying lib know that we're planning on handling `Close()` ourselves – or we need to just let it do its thing. I've opted to leave it up to the lib completely, so it can do it's retry stuff if that's ever useful.
|
Thanks for digging into this, I think this makes sense.
|
tarnfeld
added a commit
that referenced
this pull request
Aug 1, 2014
Fix nil pointer dereference panic on TCP reqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Close()closes the tpc socket, but the underlying lib is still expecting it to be open so it can do some retry logicWe either need to call
response.Hijack()early – to let the underlying lib know that we're planning on handlingClose()ourselves – or we need to just let it do its thing.I've opted to leave it up to the lib completely, so it can do it's retry stuff if that's ever useful.