Support SRV records #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to rebase the changes to get rid of the merge commit? |
|
LGTM! Do you think we could also add a test for an malformed record? |
added 3 commits
July 3, 2014 14:37
According to the RFC(https://www.ietf.org/rfc/rfc2782.txt), empty targets are legitimate and have meaning: "A Target of "." means that the service is decidedly not available at this domain."
|
Rebased; will add an extra test or two in a bit |
|
LGTM! Nice one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined in RFC2782
Example:
Declaring that service 'myservice' is available on port 8080 of node1.myservice.orls.net:
curl http://127.0.0.1:4001/v2/keys/net/orls/_tcp/_myservice/.SRV/whatever1 -XPUT -d value="100\t100\t8080\tnode1.myservice.orls.net"Would allow the following: