Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the project version to 0 #3873

Closed
wants to merge 1 commit into from
Closed

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Jan 26, 2025

Task/Issue URL:
Tech Design URL:
CC:

Description:

This PR fixes an issue where the build number wasn't being updated correctly.

The way to reproduce this issue is to check out the main branch and run bundle exec fastlane ios increment_build_number_for_version "7.154.0"`, after which you'll see that the build number doesn't change, only the Core.framework dylib version.

Steps to test this PR:

  1. Check this branch out locally and run bundle exec fastlane ios increment_build_number_for_version "7.154.0"
  2. Check that the value of CURRENT_PROJECT_VERSION is correctly updated

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested review from ayoy and removed request for ayoy January 26, 2025 18:41
@samsymons
Copy link
Contributor Author

Closing this as this should instead be fixed in a way that is compatible with the new release process.

@samsymons samsymons closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant