Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update App Store metadata to shorten NL description #3868

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

THISISDINOSAUR
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR commented Jan 24, 2025

Task/Issue URL: https://app.asana.com/0/414709148257752/1209234304165547/f
Tech Design URL:
CC:

Description:
Follow on from #3860 , the NL App Store description was too long
Also some more meta data updates from people

Steps to test this PR:

  1. Not sure we can really test without merging and then running promote_latest_testflight_to_appstore

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes also look good!

@THISISDINOSAUR THISISDINOSAUR merged commit 29b185b into main Jan 24, 2025
18 checks passed
@THISISDINOSAUR THISISDINOSAUR deleted the elle/update-metadata branch January 24, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants