Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS #3864

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Update CSS #3864

merged 2 commits into from
Jan 24, 2025

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 24, 2025

Task/Issue URL: https://app.asana.com/0/414235014887631/1209235599025435/f

Description:
Update CSS to fix an issue with the message bridge

Steps to test this PR:

  1. Use this config file https://jsonblob.com/api/1332351044923088896
  2. search for “Bread recipe” on the SERP
  3. Click the Duck.ai button. It should open the custom webview

Definition of Done (Internal Only):

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw a demo of it working. Minimal change. LGTM.

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to approve.

Bunn added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jan 24, 2025
**Required**:

Task/Issue URL:
https://app.asana.com/0/414235014887631/1209235599025435/f
iOS PR:  duckduckgo/iOS#3864
macOS PR:  duckduckgo/macos-browser#3777
What kind of version bump will this require?: Major/Minor/Patch

**Description**:
Update C-S-S version, fixing a messageBridge issue for production URLs
@Bunn Bunn merged commit f3dc651 into main Jan 24, 2025
13 checks passed
@Bunn Bunn deleted the bunn/update-css branch January 24, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants