Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab manager multi select mode #3843

Closed
wants to merge 34 commits into from
Closed

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jan 22, 2025

Task/Issue URL: https://app.asana.com/0/392891325557410/1208685664909478/f
Tech Design URL:
CC:

Description:
Adds ability to multi-select tabs.

Refactored SwiftUI top bar view to use a transparent Navigation Bar (which wasn't available when we first built this screen)

Steps to test this PR:

  1. Disable internal user
  2. Open a few tabs and browse to some web pages
  3. Smoke test previous behaviour remains the same (you can also run the bookmarks and bookmarks-multi UI tests)
  4. Enable internal user
  5. Validate UI vs Figma (iPhone and iPad)
  6. Click edit and chose "Select tabs" to get into selection mode
  7. Close all tabs from this menu should work
  8. Once in this mode selecting and closing selected tabs should work
  9. The menu in the circle with ellipsis is still WIP
  10. Long press on the tabs doesn't do anything yet (other than allow re-ordering)
  11. Validate UI on iOS 15

brindy added 26 commits January 16, 2025 11:43
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts:
#	DuckDuckGo/TabSwitcherTopBarView.swift
#	DuckDuckGo/TabSwitcherViewController.swift
# Conflicts:
#	DuckDuckGo/MainViewController.swift
#	DuckDuckGo/TabSwitcherTopBarView.swift
#	DuckDuckGo/TabSwitcherViewController.swift
#	DuckDuckGo/UserText.swift
Copy link

github-actions bot commented Jan 22, 2025

Fails
🚫

Please, make sure this PR satisfies our Definition of Done and the relevant checkbox is checked.

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against eacff65

@brindy brindy requested a review from dus7 January 23, 2025 12:11
@brindy brindy marked this pull request as ready for review January 23, 2025 12:12
@brindy brindy requested review from dus7 and removed request for dus7 January 23, 2025 12:17
@brindy
Copy link
Contributor Author

brindy commented Jan 27, 2025

Going to re-open with more changes.

@brindy brindy closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant