Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logic for firing disabled credential provider pixel #3789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Jan 10, 2025

Task/Issue URL: https://app.asana.com/0/0/1209116194072431/f
Tech Design URL:
CC:

Description:
Fixes a bug where the number of disabled events for the credential provider extension were incorrectly reported

Steps to test this PR:

  1. Testing on device, enable the extension if not already enabled.
  2. Install the app from this branch
  3. Disable the credential provider extension via System Settings
  4. Stop the app and relaunch. Check that the pixel autofill_extension_disabled is fired
  5. Keeping the extension disabled, stop and relaunch the app again. Confirm that autofill_extension_disabled is not fired again

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor Author

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug here was that the disabled pixel is fired on every app launch once autofillExtensionEnabled has been set to false (instead of just the first time autofillExtensionEnabled is update from true to false)

Copy link

@gourab99-tech gourab99-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes no sense

@amddg44 amddg44 requested a review from aataraxiaa January 10, 2025 17:04
@amddg44 amddg44 marked this pull request as ready for review January 10, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants