Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duck Player subfeature before sending to CSS #5083

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Sep 27, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208419248359318/f

Description

CSS doesn't support subfeatures, which are the basis of a phased rollout. Therefore, we combine both feature and subfeature status before sending the JSON to CSS

Steps to test this PR

Get JSON blob from linked task

Feature 1

  • Clean install using the RC above
  • Check that when the app is assigned to enabled (50%), Duck Player overlays work
  • Otherwise, check no Duck Player CSS messages are processed and/or no Duck Player overlays are shown

Feature2

  • Clean install without overriding RC
  • Check that Duck Player overlays work

UI changes

No UI changes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants