Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Tab: Customize and Settings #4590

Closed
wants to merge 110 commits into from
Closed

New Tab: Customize and Settings #4590

wants to merge 110 commits into from

Commits on Jun 27, 2024

  1. New Tab: Extract Legacy Page

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    88a669d View commit details
    Browse the repository at this point in the history

  2. extracting new tab to it's own layout / view

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    aec2e46 View commit details
    Browse the repository at this point in the history

  3. moving code out of BTF, moving also tests

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d9941bc View commit details
    Browse the repository at this point in the history

  4. properly hiding dax logo

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    55ae24c View commit details
    Browse the repository at this point in the history

  5. update APPTP banner style

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5006358 View commit details
    Browse the repository at this point in the history

  6. added new omnibar outline

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5912b82 View commit details
    Browse the repository at this point in the history

  7. fixed plugin code generation

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    0341fed View commit details
    Browse the repository at this point in the history

  8. added edit fragment option

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fb85c2e View commit details
    Browse the repository at this point in the history

  9. created a plugin for focused view

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    086424d View commit details
    Browse the repository at this point in the history

  10. ensure both views can delete saved sites

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    424756b View commit details
    Browse the repository at this point in the history

  11. added a method to open a url in the current tab

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    199332c View commit details
    Browse the repository at this point in the history

  12. unused const

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e71bd79 View commit details
    Browse the repository at this point in the history

  13. fixing references

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    72cbfd1 View commit details
    Browse the repository at this point in the history

  14. fix lint

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6064968 View commit details
    Browse the repository at this point in the history

  15. tryng to fix viewmodel tests

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3f410bd View commit details
    Browse the repository at this point in the history

  16. cleaning up merge conflict

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    bd7283e View commit details
    Browse the repository at this point in the history

  17. fix wrong apptp reference

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    55a43de View commit details
    Browse the repository at this point in the history

  18. added log for CTA

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    cc095b3 View commit details
    Browse the repository at this point in the history

  19. code format

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ee24fe2 View commit details
    Browse the repository at this point in the history

  20. fix rebase

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3200eae View commit details
    Browse the repository at this point in the history

  21. delete wrong reference

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    04a6fc8 View commit details
    Browse the repository at this point in the history

  22. delete wrong reference

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5381acd View commit details
    Browse the repository at this point in the history

  23. fix cta dismiss behaviour

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    95baf23 View commit details
    Browse the repository at this point in the history

  24. rebase

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    462d03d View commit details
    Browse the repository at this point in the history

  25. code formatting

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    969b7d3 View commit details
    Browse the repository at this point in the history

  26. add missing app tp view

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7c5e9cf View commit details
    Browse the repository at this point in the history

  27. code format

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5b12931 View commit details
    Browse the repository at this point in the history

  28. fixing viewmodel test

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    88f3181 View commit details
    Browse the repository at this point in the history

  29. New Tab: Add New Page

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    59f052a View commit details
    Browse the repository at this point in the history

  30. added new modules for new tab

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    74d473a View commit details
    Browse the repository at this point in the history

  31. moving plugins to new module

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9e38f65 View commit details
    Browse the repository at this point in the history

  32. starting to add the new UI

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    eab335d View commit details
    Browse the repository at this point in the history

  33. added more icons

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    952f737 View commit details
    Browse the repository at this point in the history

  34. added favourites plugin view

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a6d5378 View commit details
    Browse the repository at this point in the history

  35. added favourites plugin view

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e0e9ce9 View commit details
    Browse the repository at this point in the history

  36. adding remote messaging framework to the new tab sections plugin

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    bfb1264 View commit details
    Browse the repository at this point in the history

  37. added section for shortcuts

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    8430fa4 View commit details
    Browse the repository at this point in the history

  38. missing title for shortcuts

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    904abec View commit details
    Browse the repository at this point in the history

  39. added shortcuts view

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b241d21 View commit details
    Browse the repository at this point in the history

  40. adding shortcuts to the grid view

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    4d9d8e0 View commit details
    Browse the repository at this point in the history

  41. ensure omnibar is deselected after scrolling new tab

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7d8d57f View commit details
    Browse the repository at this point in the history

  42. moving to active plugin points

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fcd65e1 View commit details
    Browse the repository at this point in the history

  43. added missing AppTP view

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9a6fe83 View commit details
    Browse the repository at this point in the history

  44. aitor

    @aitorvs @malmstein
    aitorvs authored and malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9d64475 View commit details
    Browse the repository at this point in the history

  45. moving to flows and ActivePluginPoints

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f403f59 View commit details
    Browse the repository at this point in the history

  46. this should be launchedf properly

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2836bc4 View commit details
    Browse the repository at this point in the history

  47. ensure shortcuts appear

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ca81109 View commit details
    Browse the repository at this point in the history

  48. format

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    25a5644 View commit details
    Browse the repository at this point in the history

  49. add lint check for html

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    4a53166 View commit details
    Browse the repository at this point in the history

  50. fix rebase conflicts

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    bb7fb4b View commit details
    Browse the repository at this point in the history

  51. code format

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d1c3aa6 View commit details
    Browse the repository at this point in the history

  52. kotlin lint

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    eb242f4 View commit details
    Browse the repository at this point in the history

  53. fix wrong reference

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    649d891 View commit details
    Browse the repository at this point in the history

  54. proper RMF service endpoint

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1b2b8c2 View commit details
    Browse the repository at this point in the history

  55. fixing RMF model test

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    610fe06 View commit details
    Browse the repository at this point in the history

  56. fix global layout for test

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    730ed38 View commit details
    Browse the repository at this point in the history

  57. remove unncessary tests

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9a44c6c View commit details
    Browse the repository at this point in the history

  58. remove more widget tests

    @malmstein
    malmstein committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a921e70 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. fix text color highlight in omnibar

    @malmstein
    malmstein committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2988ff5 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. addressed PR Comments

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f80017f View commit details
    Browse the repository at this point in the history

  2. code formatting

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d45d9a8 View commit details
    Browse the repository at this point in the history

  3. ensure bottom sheet doesn't appear twice

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6e12de8 View commit details
    Browse the repository at this point in the history

  4. New Tab: Section Settings

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a95de2a View commit details
    Browse the repository at this point in the history

  5. added shortcut setting

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c676464 View commit details
    Browse the repository at this point in the history

  6. adding new screen for Edit New Tab Settings

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    3d86cfa View commit details
    Browse the repository at this point in the history

  7. adding new screen for Edit New Tab Settings

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2a13d66 View commit details
    Browse the repository at this point in the history

  8. created views for the settings screen

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4e76841 View commit details
    Browse the repository at this point in the history

  9. added priorities to plugins

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    53cff35 View commit details
    Browse the repository at this point in the history

  10. added database for new tab settings

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f8166b7 View commit details
    Browse the repository at this point in the history

  11. added store for settings

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8b2c445 View commit details
    Browse the repository at this point in the history

  12. switches now affect sections displayed

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a633703 View commit details
    Browse the repository at this point in the history

  13. apptp setting should only be visible if apptp was ever enabled

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    3e9d53c View commit details
    Browse the repository at this point in the history

  14. refresh sections after coming back onResume

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    1242bc5 View commit details
    Browse the repository at this point in the history

  15. added ability to reorder sections in settings

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2da98a7 View commit details
    Browse the repository at this point in the history

  16. moved grid item back at 56dp

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ca4ff60 View commit details
    Browse the repository at this point in the history

  17. ensure RMF is always shown as first section

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    dca7920 View commit details
    Browse the repository at this point in the history

  18. Apptp setting is only visible when it should

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6998678 View commit details
    Browse the repository at this point in the history

  19. properly intialise sections

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    34ec05a View commit details
    Browse the repository at this point in the history

  20. ordering should not change favoueotes

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    5bfc1e1 View commit details
    Browse the repository at this point in the history

  21. initialise setting sproperly

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a37e041 View commit details
    Browse the repository at this point in the history

  22. added test for ShortcutViewModel

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    493ca10 View commit details
    Browse the repository at this point in the history

  23. added test for RemoteMessageViewModel

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    100b631 View commit details
    Browse the repository at this point in the history

  24. fix ntp viewmodel

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e75385d View commit details
    Browse the repository at this point in the history

  25. added missing shortcuts provider

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    fbb2286 View commit details
    Browse the repository at this point in the history

  26. proper inital order of sections

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    cf8c077 View commit details
    Browse the repository at this point in the history

  27. added shimmer for new tab page

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b7febc3 View commit details
    Browse the repository at this point in the history

  28. show dax logo if no sections are to be displayed

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d8c55d9 View commit details
    Browse the repository at this point in the history

  29. ensure logo appears when no other sections visible

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6300e3a View commit details
    Browse the repository at this point in the history

  30. ensure dax logo is visible after a view is removed manually

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    9f142dc View commit details
    Browse the repository at this point in the history

  31. need to work on how to react to removing items

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ecb241f View commit details
    Browse the repository at this point in the history

  32. dax logo is shown properly

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b9aac3e View commit details
    Browse the repository at this point in the history

  33. properly updating views

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    75322dd View commit details
    Browse the repository at this point in the history

  34. remove unnecessary padding

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    db0a096 View commit details
    Browse the repository at this point in the history

  35. New Tab: Manage Shortcuts (#4688) 

    Task/Issue URL:

_Feature 1_
- [ ]
- [ ]

| Before  | After |
| ------ | ----- |
!(Upload before screenshot)|(Upload after screenshot)|
    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2ec9dd5 View commit details
    Browse the repository at this point in the history

  36. more design review

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    28a82b7 View commit details
    Browse the repository at this point in the history

  37. change touch listeners

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    36af677 View commit details
    Browse the repository at this point in the history

  38. clean up shortcuts long press

    @malmstein
    malmstein committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7e6f53f View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. enable shortcuts by default

    @malmstein
    malmstein committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    79f6e83 View commit details
    Browse the repository at this point in the history

  2. first round of design review changes

    @malmstein
    malmstein committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6974210 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. code format

    @malmstein
    malmstein committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    5dfa645 View commit details
    Browse the repository at this point in the history

  2. clean up paddings

    @malmstein
    malmstein committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8c83711 View commit details
    Browse the repository at this point in the history

  3. more chabges

    @malmstein
    malmstein committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    31cce78 View commit details
    Browse the repository at this point in the history

  4. cleanup padiongs

    @malmstein
    malmstein committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    40efc34 View commit details
    Browse the repository at this point in the history

  5. cleanup padiongs

    @malmstein
    malmstein committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    0405ed5 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. manage shortcuts chck items:

    @malmstein
    malmstein committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a7df2c6 View commit details
    Browse the repository at this point in the history

  2. ensure grid changes layout or orientation:

    @malmstein
    malmstein committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    14012d4 View commit details
    Browse the repository at this point in the history

  3. ensure setting store is not repeated

    @malmstein
    malmstein committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    fd1698b View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. fixes v2 for design review

    @malmstein
    malmstein committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7a59489 View commit details
    Browse the repository at this point in the history

  2. code cleaning

    @malmstein
    malmstein committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ff1601d View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. favourites view in focusedview is always expanded

    @malmstein
    malmstein committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3ffbac4 View commit details
    Browse the repository at this point in the history