Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup 'Add also community_signature' #1778

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fixup 'Add also community_signature' #1778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions duckdb.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ index 8a278832b1..b9447440de 100644
#else
string default_endpoint = ExtensionRepository::DEFAULT_REPOSITORY_URL;
diff --git a/src/main/extension/extension_load.cpp b/src/main/extension/extension_load.cpp
index 65438aa8ec..97fce63d04 100644
index 65438aa8ec..591c759a7f 100644
--- a/src/main/extension/extension_load.cpp
+++ b/src/main/extension/extension_load.cpp
@@ -175,7 +175,13 @@ bool ExtensionHelper::TryInitialLoad(DBConfig &config, FileSystem &fs, const str
Expand Down Expand Up @@ -390,7 +390,7 @@ index 65438aa8ec..97fce63d04 100644
+ signature[j] = ((uint8_t *)exe)[4 + signature_offset + j];
+ }
+ bool any_valid = false;
+ for (auto &key : ExtensionHelper::GetPublicKeys(config.options.allow_unsigned_extensions)) {
+ for (auto &key : ExtensionHelper::GetPublicKeys(config.options.allow_community_extensions)) {
+ if (duckdb_mbedtls::MbedTlsWrapper::IsValidSha256Signature(key, signature, two_level_hash)) {
+ any_valid = true;
+ break;
Expand Down