Skip to content

fix adbc test imports #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evertlammerts merged 1 commit into from
Dec 8, 2025
Merged

fix adbc test imports #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions tests/fast/adbc/test_adbc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import pytest

adbc_driver_manager = pytest.importorskip("adbc_driver_manager")
adbc_driver_manager_dbapi = pytest.importorskip("adbc_driver_manager.dbapi")
adbc_driver_duckdb = pytest.importorskip("adbc_driver_duckdb")
pyarrow = pytest.importorskip("pyarrow")

Expand All @@ -14,7 +15,7 @@

@pytest.fixture
def duck_conn():
with adbc_driver_manager.dbapi.connect(driver=driver_path, entrypoint="duckdb_adbc_init") as conn:
with adbc_driver_manager_dbapi.connect(driver=driver_path, entrypoint="duckdb_adbc_init") as conn:
yield conn


Expand Down Expand Up @@ -93,7 +94,7 @@ def test_commit(tmp_path):
table = example_table()
db_kwargs = {"path": f"{db}"}
# Start connection with auto-commit off
with adbc_driver_manager.dbapi.connect(
with adbc_driver_manager_dbapi.connect(
driver=driver_path,
entrypoint="duckdb_adbc_init",
db_kwargs=db_kwargs,
Expand All @@ -103,7 +104,7 @@ def test_commit(tmp_path):
cur.adbc_ingest("ingest", table, "create")

# Check Data is not there
with adbc_driver_manager.dbapi.connect(
with adbc_driver_manager_dbapi.connect(
driver=driver_path,
entrypoint="duckdb_adbc_init",
db_kwargs=db_kwargs,
Expand All @@ -122,7 +123,7 @@ def test_commit(tmp_path):

# This now works because we enabled autocommit
with (
adbc_driver_manager.dbapi.connect(
adbc_driver_manager_dbapi.connect(
driver=driver_path,
entrypoint="duckdb_adbc_init",
db_kwargs=db_kwargs,
Expand Down Expand Up @@ -294,7 +295,7 @@ def test_large_chunk(tmp_path):
db.unlink()
db_kwargs = {"path": f"{db}"}
with (
adbc_driver_manager.dbapi.connect(
adbc_driver_manager_dbapi.connect(
driver=driver_path,
entrypoint="duckdb_adbc_init",
db_kwargs=db_kwargs,
Expand All @@ -320,7 +321,7 @@ def test_dictionary_data(tmp_path):
db.unlink()
db_kwargs = {"path": f"{db}"}
with (
adbc_driver_manager.dbapi.connect(
adbc_driver_manager_dbapi.connect(
driver=driver_path,
entrypoint="duckdb_adbc_init",
db_kwargs=db_kwargs,
Expand Down Expand Up @@ -348,7 +349,7 @@ def test_ree_data(tmp_path):
db.unlink()
db_kwargs = {"path": f"{db}"}
with (
adbc_driver_manager.dbapi.connect(
adbc_driver_manager_dbapi.connect(
driver=driver_path,
entrypoint="duckdb_adbc_init",
db_kwargs=db_kwargs,
Expand Down
Loading