Add filename_pattern to to_parquet Python API #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great if this can be considered to close the gap in the python API. |
evertlammerts
previously approved these changes
Dec 2, 2025
Collaborator
evertlammerts
left a comment
evertlammerts
left a comment
There was a problem hiding this comment.
lgtm. if the checks pass we can merge.
Author
|
Looks like we may need one more +1 since you committed here @evertlammerts - do you have anyone else I can tag in? Thanks! |
evertlammerts
force-pushed
the
mb/filename_pattern
branch
from
6833034 to
5cb2afb
Compare
Collaborator
|
Rebased onto v1.4-andium so this makes it into 1.4.3 (planned for next week) |
Collaborator
No worries, when the tests pass I'll land it. |
Author
|
Amazing, thank you for your help and quick response! We are loving DuckDB and super impressed with performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178