Merged
Conversation
…purpose outside of CI anyways. It could be made to work locally if we add a separate rule to clone the repo only if it doesn't exist, but for now moving it is fine I think
…ng with spark though
Tishj
force-pushed
the
add_lakekeeper_to_ci
branch
from
87f411f to
95ebcd7
Compare
Tmonster
reviewed
Apr 7, 2025
Collaborator
Tmonster
left a comment
Tmonster
left a comment
There was a problem hiding this comment.
Looks good, just a couple of comments
| export POLARIS_CLIENT_ID=$(cat polaris_client_id.txt) | ||
| export POLARIS_CLIENT_SECRET=$(cat polaris_client_secret.txt) | ||
| make test_release No newline at end of file | ||
| ./build/release/test/unittest "$PWD/test/*" --list-test-names-only || true |
Collaborator
There was a problem hiding this comment.
any specific reason we want to list the test names and then run the tests?
Collaborator
Author
There was a problem hiding this comment.
To verify that the tests we care about are actually being run
scripts/data_generators/generate_spark_rest/generate_iceberg_spark_rest.py
Show resolved
Hide resolved
| ) | ||
|
|
||
| statement ok | ||
| attach 'demo' as my_datalake ( |
Collaborator
There was a problem hiding this comment.
We also support the OAUTH2_SCOPE and OAUTH2_SERVER_URI in the create secret statement right?
Can we also get a test where those values are initialized there?
Collaborator
Author
There was a problem hiding this comment.
I don't think we do currently, that's part of #142
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Lakekeeper to CI, the steps to set up Lakekeeper are largely taken from https://github.com/lakekeeper/lakekeeper/tree/main/examples/access-control-simple
Using the existing
data_generatorsin the scripts directory we populate Lakekeeper with TPCH and run a subset of the TPCH tests on it (test_lakekeeper_tpch.test).