Pin to duckdb v0.10.2 to avoid view dependencies #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip duckdb v0.10.3 to avoid issues with view dependency enforcement. This will be fixed in 0.10.4 by the enable_view_dependencies configuration setting (which is set to false by default).
guenp
changed the title
guenp
changed the title
jwills
reviewed
May 30, 2024
| # add dbt-core to ensure backwards compatibility of installation, this is not a functional dependency | ||
| "dbt-core>=1.8.0", | ||
| ], | ||
| extras_require={"glue": ["boto3", "mypy-boto3-glue"], "md": ["duckdb>=0.10.2"]}, | ||
| extras_require={"glue": ["boto3", "mypy-boto3-glue"], "md": ["duckdb==0.10.2"]}, |
There was a problem hiding this comment.
I think this change isn't needed? The constraint on the top-level dependency should prevent 0.10.3 from being installed if the user requests dbt-duckdb[md].
There was a problem hiding this comment.
Maybe not, but I don't think it does any harm
There was a problem hiding this comment.
This is only used by the CI right now
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a constraint to setup.py to skip
duckdbv0.10.3 and avoid issues with view dependency enforcement. This will be fixed in 0.10.4 and above by theenable_view_dependenciesconfiguration setting (which is set to false by default).Related issue: duckdb/duckdb#12191