Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically link C-runtime for MSVC Windows #221

Merged
merged 4 commits into from
Jan 23, 2022
Merged

Statically link C-runtime for MSVC Windows #221

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fcfbd12
statically link c-runtime for msvc windows
ducaale Jan 16, 2022
8d2da74
use rustflags in CI instead of config.toml
ducaale Jan 17, 2022
e4a3d81
use a seperate step for setting rustflags env
ducaale Jan 23, 2022
f01f122
enable lto in CI releases only
ducaale Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,15 @@ jobs:
- os: windows-latest
target: x86_64-pc-windows-msvc
flags: --features=native-tls
rustflags: -C target-feature=+crt-static
steps:
- uses: actions/checkout@v2

- name: Set RUSTFLAGS env variable
if: matrix.job.rustflags
shell: bash
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I set shell to bash, RUSTFLAGS will not get passed to cargo in the next step.

run: echo "RUSTFLAGS=${{ matrix.job.rustflags }}" >> $GITHUB_ENV

- name: Build target
uses: actions-rs/cargo@v1
with:
Expand All @@ -90,6 +97,7 @@ jobs:

- id: get_version
uses: battila7/get-version-action@v2

- name: Package
shell: bash
run: |
Expand Down