Unity downloadhandler fix #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the DELETE method does not return a body, therefore there is no download handler.
borntocompile
requested review from
FancySensei,
SlaveykoSlaveykov-Dubit,
danhalldubit,
kkjamie,
phil-allcock and
zieglerkevin
danhalldubit
approved these changes
Nov 4, 2019
zieglerkevin
approved these changes
Nov 4, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not every http method has to return a body, so for example when using the method DELETE, the response attempts to load the download handlers data. However, Unity has not created the object for it so it will return null.