Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

That .stderr files are missing results merely in a warning allows forgetting to check them in #169

Closed
Samyak2 opened this issue Apr 29, 2022 · 1 comment · Fixed by #170
Closed

That .stderr files are missing results merely in a warning allows forgetting to check them in #169

Samyak2 opened this issue Apr 29, 2022 · 1 comment · Fixed by #170

Comments

@Samyak2
Copy link

Samyak2 commented Apr 29, 2022

Thank you for the crate! We're using it in michie.

We ended up merging a PR that adds a new compile_fail test and omits the corresponding .stderr file. Perhaps missing .stderr files could fail the test instead of warn? That should prevent such an error.

@mightyiam
mightyiam added a commit to mobusoperandi/michie that referenced this issue Apr 29, 2022
@mightyiam @Samyak2
workaround for dtolnay/trybuild#169
32f241c 
Co-authored-by: Samyak S Sarnayak <[email protected]>
mightyiam added a commit to mobusoperandi/michie that referenced this issue Apr 29, 2022
@mightyiam
Merge pull request #104 from mobusoperandi/compile-fail-check-wip
95c7568 
workaround for dtolnay/trybuild#169
@dtolnay dtolnay mentioned this issue Apr 29, 2022
Merged
@mightyiam
Copy link

Thank you, @dtolnay !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail test on creating any new stderr files dtolnay/trybuild
2 participants
@mightyiam @Samyak2