Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parenthesization of field expressions in function calls #1786

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Fix parenthesization of field expressions in function calls #1786

merged 3 commits into from
Nov 29, 2024

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Nov 29, 2024 •
edited
Loading

(thing.field)() is not equivalent to thing.field().

But (thing.0)() and thing.0() are equivalent.

@dtolnay
Add test of parentheses needed in call of field
0e5c568 
    ---- test_fixup stdout ----
    thread 'test_fixup' panicked at tests/test_expr.rs:717:9:
    original: (self . f) ()
    reconstructed: self . f ()
@dtolnay
Fix parenthesization of field expressions in function calls
48d0101
@dtolnay dtolnay merged commit f9aa206 into master Nov 29, 2024
30 checks passed
@dtolnay dtolnay deleted the fieldcall branch November 29, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dtolnay