Expose non-impl-Trait iterator return types #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a482734.
This reverts commit e8a9292.
error[E0502]: cannot borrow `generics.params` as mutable because it is also borrowed as immutable
--> tests/test_iterators.rs:81:25
|
77 | let _ = generics
| --------
| |
| _____________immutable borrow occurs here
| |
78 | | .lifetimes()
| |____________________- a temporary with access to the immutable borrow is created here ...
...
81 | .unwrap_or_else(|| {
| ^^ mutable borrow occurs here
82 | let lifetime: Lifetime = parse_quote!('a);
83 | generics.params.insert(
| --------------- second borrow occurs due to use of `generics.params` in closure
...
88 | });
| - ... and the immutable borrow might be used here, when that temporary is dropped and runs the destructor for type `impl Iterator<Item = &LifetimeParam>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1718.
There is no syntax in
impl Trait<'a>to express that the underlying type either does not have aDropimpl or has a dropck eyepatch:unsafe impl<#[may_dangle] 'a> Drop.