Adding missed unit test cases #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your time & patience to review this PR.
We are researchers focusing on Rust unit tests. By examine the existing code, we found following unit tests can be added to improve the repo's overall unit test coverage.
We only manually changed our assert statements to make it consistent with existing macros and move the error tests to its correct location.
As for the unit tests, we found the
from_strmethod for Comparator & Prerelease struct are rarely tested and there are many corner error cases in Version/VersionSeq are missed.If you have any questions, comments or feedback, please let us know.
Thanks!