Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track raw pointers in miri CI run #38

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

5225225
Copy link
Contributor

@5225225 5225225 commented Nov 28, 2021

I'm not sure if this is even correct, but from reading the docs (https://docs.github.com/en/actions/learn-github-actions/environment-variables), this should export a flag that's visible to miri.

@5225225
Copy link
Contributor Author

5225225 commented Nov 28, 2021

I'm going to re-introduce the bug to see if it's actually caught in the CI, then remove that commit once I know it works.

@5225225
Copy link
Contributor Author

5225225 commented Nov 28, 2021

okay cool it worked :) (https://github.com/dtolnay/ryu/runs/4347054082?check_suite_focus=true for reference but i have no idea how long runs are kept for)

@5225225 5225225 marked this pull request as ready for review November 28, 2021 19:58
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Screenshot from 2021-11-28 11-58-54

@dtolnay dtolnay merged commit 862e6e5 into dtolnay:master Nov 28, 2021
@5225225 5225225 deleted the track-raw-ptrs-ci branch November 28, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants