Mention quotes for toolchain #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikhuijzer
commented
Jun 26, 2023
| @@ -86,15 +88,15 @@ compiler support. | |||
| # offset, which may be written in years, months, weeks, or days. | |||
| - uses: dtolnay/rust-toolchain@master | |||
| with: | |||
| toolchain: stable 18 months ago | |||
| toolchain: 'stable 18 months ago' | |||
There was a problem hiding this comment.
The quotes are not necessary here, but it's a good habit to use quotes in YAML. Or as someone on HN said it: "save yourself pain. Always quote" (https://news.ycombinator.com/item?id=34509789).
bergmark
reviewed
Jul 13, 2023
| @@ -43,6 +43,8 @@ All inputs are optional. | |||
| Rustup toolchain specifier e.g. <code>stable</code>, <code>nightly</code>, <code>1.42.0</code>, <code>nightly-2022-01-01</code>. | |||
| <b>Important: the default is to match the @rev as described above.</b> | |||
| When passing an explicit <code>toolchain</code> as an input instead of @rev, you'll want to use "dtolnay/rust-toolchain@master" as the revision of the action. | |||
| <b>Also important: use quotes to ensure that the right toolchain version is passed to this GitHub Action.</b> | |||
| For example, specify <code>toolchain: '1.70'</code> (with quotes) because <code>toolchain: 1.70</code> will be parsed as <code>toolchain: 1.7</code>. | |||
There was a problem hiding this comment.
Couldn't this be fixed instead? I assume it is only an issue if you parse through serde_yaml::Value?
fn main() {
dbg!(serde_yaml::from_str::<Foo>("v: 1.70").unwrap());
}
#[derive(serde::Deserialize, Debug)]
struct Foo {
v: String
}
[src/main.rs:2] serde_yaml::from_str::<Foo>("v: 1.70").unwrap() = Foo {
v: "1.70",
}
0xbe7a
added a commit
to 0xbe7a/rattler-build
that referenced
this pull request
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've re-learned the importance of quotes the hard way 😅
Preview