Update where-clause position of generic associated types according to rust-lang issue #89122 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rust syntax (see rust issue #89122)
dtolnay
requested changes
Jan 5, 2023
src/item.rs
Outdated
| self.neverbreak(); | ||
| self.ibox(-INDENT); | ||
| self.ty(&item.ty); | ||
| self.end(); | ||
| self.word(";"); | ||
| self.where_clause_oneline_semi(&item.generics.where_clause); |
There was a problem hiding this comment.
I don't think this change is correct. Where-clause is not allowed after the type on type aliases.
There was a problem hiding this comment.
Wow that's true. Reverted the code here.
dtolnay
reviewed
Jan 5, 2023
src/item.rs
Outdated
| self.neverbreak(); | ||
| self.ty(default); | ||
| self.where_clause_oneline_semi(&trait_item.generics.where_clause); |
There was a problem hiding this comment.
Please move this line out of the if block since it is identical to the other branch.
dtolnay
changed the title
where clause position according to rust-lang issue #89122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 😀
When I'm using this formatter I noticed it's not yet supporting the recent rust's syntax update.
So I'm sending you a small patch to fix it. Thanks! 🙇
Sample diff from my code:
https://user-images.githubusercontent.com/1488411/210623996-300f6a29-f730-4e1d-a16f-d95133b66f91.png
(My test cases is not enough I think, I only tested the type alias in impl_item. But it's trivial so assume it's okay...)