Address feedback from LPC #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
force-pushed
the
lpc-feedback
branch
3 times, most recently
from
ff4623b
to
e0b1c81
Compare
Also specify that div-by-zero results in zero and mod-zero results in the source value Signed-off-by: Dave Thaler <[email protected]>
dthaler
force-pushed
the
lpc-feedback
branch
from
e0b1c81
to
9246c66
Compare
Note that imm is signed Fix typo in Appendix Signed-off-by: Dave Thaler <[email protected]>
As reported by Shung-Hsi Yu Signed-off-by: Dave Thaler <[email protected]>
In preparation for adding instructions that use it Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
dthaler
force-pushed
the
lpc-feedback
branch
6 times, most recently
from
53a0457
to
7bb1801
Compare
dthaler
changed the title
dthaler
force-pushed
the
lpc-feedback
branch
from
7bb1801
to
605ca54
Compare
This is still missing what ISA version they are in. Are they all available in ISA version 1? Signed-off-by: Dave Thaler <[email protected]>
dthaler
force-pushed
the
lpc-feedback
branch
from
605ca54
to
f155b3b
Compare
|
I'm going to merge this into the update branch so anyone newly looking at PR #4 will see the corrected text instead of reporting the same issues. Please review the updates there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Fixes #3
Signed-off-by: Dave Thaler [email protected]