-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Site wxscs.com #1620
Add Site wxscs.com #1620
Conversation
I noticed before it only worked when I clicked the plugin when on the index page. I fixed it so it works on the chapter page too. |
@phazei It's missing an implementation of:
Also, please add your name to readme.md and package.json and squash the commits.
Can you provide the script? Or better yet, add a page to the wiki describing what you did? If it can help others, that could save me and the others a lot of work. |
|
66e0526
to
ef0e9bd
Compare
I updated the requested changes and squashed the commits. I wanted to note that the getFirstImgSrc helper doesn't work if the selector is the img element itself. Also, there are some things that aren't available on anything but the index page, like the book cover, and description. If someone clicks the plugin while on a chapter page, it mostly works, but it tries to grab stuff from the wrong pages. For the chapters, it's done async, so I can go and fetch whatever. But everything else is synchronous. I did what I could to check if it's the index page and if not, grab it and cache the DOM of the index page so the items that are on it can be grabbed without grabbing it over and over again. But the onLoadFirstPage isn't called via "await". I think if it were, it would allow the parsers to have more time to set up anything unique that might be on a site. Right now that can only be done when grabbing the chapters, but by then everything else has already been called. |
Thank you for your efforts.
Please raise an issue
I have stopped trying to make WebToEpub work when a ToC is not supplied. (IMHO Not worth the effort to write, test and maintain.) If it worries you, I'd suggest checking WebToEpub has been given a ToC in getChapterUrls(), and if not, give user a warning message. |
Additional, there were 2 eslint warnings in the text you supplied. I've pushed a fix. |
This addresses this issue:
#1619
It adds support for https://www.wxscs.com with multi-page support.
I used WattpadParser as a reference since it was the only one I could find that supported multi-page.
I'm continually impressed with Claude Sonnet, I gave it about 2 dozen parsers, top/bottom 12 based on size, asked it if anything had multi-page support, had a discussion on how it worked, gave it the html for the index and a random 3 page chapter, and it one shot a completely working extension. I've been a dev for 20 years, and it blows my mind every time I do something like this.
I tested it out on a few books on the site, worked great.