Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site https://novelnext.com/ #1287

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ktrin-u
Copy link
Contributor

@ktrin-u ktrin-u commented Apr 22, 2024

  • lint tests ok (reached Wrote Zip to disk)
  • unit tests passed (Tests completed in 512 milliseconds. 566 assertions of 566 passed, 0 failed.)
  • added name to package.json and readme.md

Been a long time user (and fan) of the plugin, hope to start contributing by adding parsers for the sites I visit.

@dteviot
Copy link
Owner

dteviot commented Apr 23, 2024

@ktrin-u

I hate to tell you this, considering the effort you put in, but the site https://novelnext.com/ is just another alias for https://allnovelnext.com/. So, you didn't need to write a new parser, you just needed to register another hostname to the NovelfullParser. See: https://github.com/dteviot/WebToEpub/blob/ExperimentalTabMode/plugin/js/parsers/NovelfullParser.js#L3-L35
As I'd love to give you credit for your work, if you like to amend your commit, I'll be happy to accept.

Note,

  1. You might like to add https://novelnext.net/ as another alias as well.
  2. Please add in alphabetical order, it makes it easier to check if an alias has already been added.

- added alias https://novelfull.com
- added alias https://novelfull.net
- lint tests ok (reached Wrote Zip to disk)
- unit tests passed (Tests completed in 631 milliseconds.
566 assertions of 566 passed, 0 failed.)
- added name to package.json and readme.md
@ktrin-u ktrin-u force-pushed the ExperimentalTabMode branch from fec6680 to d8ac1e0 Compare April 23, 2024 23:39
@dteviot dteviot merged commit 3678bae into dteviot:ExperimentalTabMode Apr 24, 2024
@dteviot
Copy link
Owner

dteviot commented Apr 24, 2024

@ktrin-u

Firstly, thank you very much for your contribution. It's aways a happy occasion to have another contributor.
Second, I apologize for not being clearer in my previous comment. You did not need to include the NovelNextParser.js file, just registering another hostname would have been sufficient.
However, it's not a problem. I've deleted the unneeded file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants