Fix #1118 - Update FanFictionParser.js #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for loading inconsistent caching issue on ff.net Update FanFictionParser.js Removed shortUri double-negate; code will run functionally equivalent.
|
This is a fix for bug #1118 - not sure why it didn't link correctly; must have been a check-in issue. |
|
Note regarding this fix, if too many chapters have the caching issue in a short timeframe it can still result in temporary failures. It's not a perfect fix, but there are no perfect fixes when the issue is serverside. The above issue can be fairly effectively resolved by setting 30 seconds per chapter if it crops up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for loading inconsistent caching issue on ff.net; automatically checks secondary link upon any failure to retrieve chapter or read chapter text. Separate link calls info directly without interacting with broken caching. Uses existing throttle logic for second call to avoid CloudFlare detection.
Note: The detection could be narrowed down more to detect page layout and specific error message; This is not done because this method does actually resolve several other rare chapter load issues that have occurred in the last year.