-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set 1 sec/chapter as default download rate #1378
Comments
Just want to tack an addendum on here, it might be worth setting the rate parameter as a parser variable; different sites are 'good' at different speeds, CloudFlare pretty much demands 3-5 seconds depending on the domain. |
@Kiradien |
"Save Value on a per site basis" would be a potential starting point for it, so long as the default for each site was configurable via its respective Parser.js. It's probably the 'best' solution, but also the most complicated. The 'easiest' alternative is to have an extra object variable in Parser.js. amounting to [Minimum Delay] = 0, and calling Math.max(manualDelayPerChapterValue, this.[Minimum Delay]) before util.sleep. The main goal of this issue is to reduce the root cause of many-a-ticket, but the 1-second-delay is a stopgap without extensibility. There are dozens of ways to resolve it, aiming for by-domain configuration just seems best to me - whether that setting is code-only or not. |
- Set basic parser to null/0 as minimum delay - Set fanfiction parser to 3 seconds - Set ScribbleHub parser to 3 seconds - Added override to allow users to bypass minimum delay - Selected Delay will be used if larger than default minimum
Wow, I'm getting back to this message late, I blame travelling. We can also, if needed, set the global default minimum of Parser.js to 1000 for 1 second, if needed, but it does seem like a more tailored option might be better. It's tested and works for ScribbleHub and Fanfiction.net in the above changeset, but those are just the ones I remember using Cloudflare. The question is: Do we want to go with this approach? |
…rate #1378 create default parser rate
Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes. |
Updated version (0.0.0.167) has been submitted to Firefox and Chrome stores. |
From @gamebeaker
The text was updated successfully, but these errors were encountered: