Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScribbleHub extractor seems to be broke #1373

Closed
fake-name opened this issue Jul 7, 2024 · 3 comments · Fixed by #1374
Closed

ScribbleHub extractor seems to be broke #1373

fake-name opened this issue Jul 7, 2024 · 3 comments · Fixed by #1374

Comments

@fake-name
Copy link
Contributor

fake-name commented Jul 7, 2024

Describe the bug
Trying to convert a scribblehub page to epub fails with an error, generating a ~4kb epub file.

Error: Could not find content element for web page 'https://www.scribblehub.com/series/997267/maou-shoujo-magical-chaos/'.
    at chrome-extension://akiljllkbielkidmammnifcnibaigelm/js/Parser.js:501:23
    at async Promise.all (index 0)
    at async ScribblehubParser.fetchWebPages (chrome-extension://akiljllkbielkidmammnifcnibaigelm/js/Parser.js:470:17)

To Reproduce
Steps to reproduce the behavior:

  1. Go to a series page 'https://www.scribblehub.com/series/997267/maou-shoujo-magical-chaos/'
  2. Try to save as epub
  3. If you include the info page (the first page the chapter list extractor finds), that page fails to extract, generating the above exception.

Expected behavior
Previously, this stuck the series info page as the first "chapter" in the book, which was super handy.

Additional context

I think this can be fixed as easily as changing the content selector to div.fic_row, div#chp_raw.

fake-name added a commit to fake-name/WebToEpub that referenced this issue Jul 7, 2024
@fake-name
Copy link
Contributor Author

Ok, I managed to load the unpacked extension and can confirm that change resolves the issue. See #1374

@dteviot
Copy link
Owner

dteviot commented Jul 7, 2024

@fake-name

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing.

@fake-name
Copy link
Contributor Author

fake-name commented Jul 7, 2024

Test version for chrome at least seems to be working.

OTOH, scribble hub seem to have ALSO changed their markup, so the chapter extraction is no longer picking up the series page, rendering the whole change moot. so ¯\_ (ツ)_/¯.

Ugh.

Never mind, it turns out it was only triggering the code-path in question if in you had the Add Page with Chapters to Chapters List option checked. It is indeed fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants