Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing epub from Library does not reset include status #1365

Closed
Kiradien opened this issue Jun 30, 2024 · 3 comments
Closed

Removing epub from Library does not reset include status #1365

Kiradien opened this issue Jun 30, 2024 · 3 comments
Labels
Status: Completed

Comments

@Kiradien
Copy link
Collaborator

Describe the bug
When adding a chapter to an epub, it automatically registers the story in your Reading List. Deleting the epub (often to resolve generation issues) does not reset this status, leaving the chapters forever unchecked.

To Reproduce
Steps to reproduce the behavior:

  1. Add a story to the library
  2. Remove the story from the library
  3. Open the page again, epub is gone but still in reading list.

Expected behavior
Removal from library also removes from reading list.

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version [WebToEpub 0.0.0.160] [Chrome 126.0.6478.127]

Additional context
A pull request for this fix will be in place soon. This was a complex but low priority problem that has existed for a fairly long time and just annoyed me enough today to dig into it. Complex enough that it absolutely needs a ticket.
Kiradien added a commit to Kiradien/WebToEpub that referenced this issue Jun 30, 2024
@Kiradien
dteviot#1365 - Update readinglist when removing epub
ea2b904 
- Added userpreferences to Library
- Added try-delete to readingList with boolean return value should status be required.
- called readingList through userPreferences object in Library
@Kiradien
Copy link
Collaborator Author

Pull Request #1366 fixes this.

dteviot added a commit that referenced this issue Jul 3, 2024
@dteviot
Merge pull request #1366 from Kiradien/Update-reading-list-status-on-…
a51214c 
…delete-epub

#1365 - Update readinglist when removing epub
@dteviot
Copy link
Owner

dteviot commented Jul 3, 2024

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing.

@dteviot
Copy link
Owner

dteviot commented Aug 23, 2024

Updated version (0.0.0.167) has been submitted to Firefox and Chrome stores.
Firefox version is available now.
Chrome might be available in a few hours to 21 days.

@dteviot dteviot closed this as completed Aug 23, 2024
@gamebeaker gamebeaker mentioned this issue Sep 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dteviot @Kiradien