Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Update Parser for Pages with Different Format on --> https://chaleuria.com/ #1346

Closed
plsbenice-immadeofjelly opened this issue Jun 13, 2024 · 4 comments

Comments

@plsbenice-immadeofjelly
Copy link

plsbenice-immadeofjelly commented Jun 13, 2024

Hello! :D

There's not quite an issue with this site per se, but some pages on this source have a different format whereby the body content is wrapped in a different element which the current parser doesn't account for and I was wondering if the parser could be updated to also address the second format please? Also, I think the heading is still <h1> so that's no issue there.

Example TOC: https://chaleuria.com/novels/complete-guide-use-care-personal-assistant/


Current Format Webtoepub Works For (Including the Table of Contents): https://chaleuria.com/novels/complete-guide-use-care-personal-assistant/chapter-030/

CSS Selector for Body Content:

.entry-content

Different Format Webtoepub Cannot Parse: https://chaleuria.com/cgpa-c031/

CSS Selector for Body Content:

div[class^='elementor-widget-container']


And, I've tried using the Default Parser for the chapters with the divergent format, but to no avail, so came here hoping to receive a fix to this issue~ Thank you very much for your help again! xx

Kiradien added a commit to Kiradien/WebToEpub that referenced this issue Jun 14, 2024
Bugfix to handle multiple page formats used by paid content.
@Kiradien
Copy link
Collaborator

There's a bit of a format difference between the format between the standard and paid chapter formats, most notably chapter titles, but I've thrown up a pull request with this fix in mind.
The fix has a chance of running into issues in the future if chaleuria shifts to using both styles in a single page, but I can't see it in existing pages.

dteviot added a commit that referenced this issue Jun 15, 2024
#1346 - Update ChaleuriaParser.js to handle multiple formats
@dteviot
Copy link
Owner

dteviot commented Jun 15, 2024

@plsbenice-immadeofjelly

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:

  • Untested (by me)

@Kiradien Thank you for your hard work.

@plsbenice-immadeofjelly
Copy link
Author

@Kiradien @dteviot

Thank you both!!! :D It worked perfectly!! <3

@dteviot
Copy link
Owner

dteviot commented Jun 16, 2024

@plsbenice-immadeofjelly

Updated version (0.0.0.160) has been submitted to Firefox and Chrome stores.
Firefox version is available now.
Chrome might be available in a few hours to 21 days.

@dteviot dteviot closed this as completed Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants