Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webnovel.com (Qidian) all fanfic chapters missing title #1342

Closed
sRamosDev opened this issue Jun 10, 2024 · 4 comments
Closed

webnovel.com (Qidian) all fanfic chapters missing title #1342

sRamosDev opened this issue Jun 10, 2024 · 4 comments

Comments

@sRamosDev
Copy link

sRamosDev commented Jun 10, 2024

Describe the bug
It seems like something changed in webnovel's code because now no chapter has a title and its full of <div> and <i>.

To Reproduce
Steps to reproduce the behavior:

  1. Go to: Book example
  2. Download book

Screenshots
Before:

Screenshot 2024-06-10 013524

After:

Screenshot 2024-06-10 013623

@Kiradien
Copy link
Collaborator

Kiradien commented Jun 10, 2024

Yeah, this bug has been going on for a few days along with a few intermittent bugs. They changed the page style when viewing and the chapter title is no longer within the div.page h1 it was originally in.

I've got a fix sitting in a branch somewhere, I'll cherry-pick the part you need and add a pull request. Webnovel's been a bit weird since these changes went in, sometimes throwing random errors like HTTP 445, so I have a bunch of fixes that may or may not come up in the future.

Kiradien added a commit to Kiradien/WebToEpub that referenced this issue Jun 10, 2024
Re-added webnovel chapter title. Removed excess links added at bottom of page.
dteviot added a commit that referenced this issue Jun 11, 2024
#1342 - Update QidianParser.js for new page style
@dteviot
Copy link
Owner

dteviot commented Jun 11, 2024

@seba11998

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:

For my notes: 31 minutes work

dteviot added a commit that referenced this issue Jun 11, 2024
Also, minor code update for QidianParser.
See: #1342
@sRamosDev
Copy link
Author

sRamosDev commented Jun 13, 2024

Thank you, it works. The xhtml still has a bunch of extra <i> and <div> but the main problem is solved. Thank you so much.
Screenshot 2024-06-13 023338

Also, like @Kiradien mentioned, webnovel sometimes shows an error 445 when downloading a lot of chapters, and the current extension fails to handle that a times.

@dteviot
Copy link
Owner

dteviot commented Jun 16, 2024

@seba11998 @Kiradien

Updated version (0.0.0.160) has been submitted to Firefox and Chrome stores.
Firefox version is available now.
Chrome might be available in a few hours to 21 days.

@dteviot dteviot closed this as completed Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants