Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update support for ncode.syosetu.com #1210

Closed
SpiralBaka opened this issue Feb 20, 2024 · 10 comments
Closed

Please update support for ncode.syosetu.com #1210

SpiralBaka opened this issue Feb 20, 2024 · 10 comments

Comments

@SpiralBaka
Copy link

SpiralBaka commented Feb 20, 2024

they started splitting table of contents into several page with 100 link per page

for example, this novel:
https://ncode.syosetu.com/n8740ce/

this is its 'pager box'

<div` class="novelview_pager-box">
<div class="novelview_pager">
<span class="novelview_pager-first">最初へ</span>
<span class="novelview_pager-before">前へ</span>
<a href="/n8740ce/?p=2" class="novelview_pager-next">次へ</a>
<a href="/n8740ce/?p=4" class="novelview_pager-last">最後へ</a>
</div><!--novelview_pager-->
<div class="novelview_result-stats">1&nbsp;~&nbsp;100&nbsp;部分を表示中</div>
</div><!-- /.novelview_pager-box `-->

as you can see, it's split into 4 pages, I'd like to get all pages at once.

also, I'd like to get novel info like with many sites. this is its info page (作品情報):
https://ncode.syosetu.com/novelview/infotop/ncode/n8740ce/

in that page, I'd like everything in this tag:
<div class="clearfix">

@dteviot
Copy link
Owner

dteviot commented Feb 20, 2024

@SpiralBaka

I received this patch #1201 from @ImmortalDreamer a few days ago for Syosetu.
Has been merged into the experimental branch, but versions in stores have not been updated yet.

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me and ImmortalDreamer know how it goes.

@ImmortalDreamer
Copy link
Contributor

#1201 fixes the issue with pagination, yeah.
I won't be able to work on the information page until this weekend, tho.
Will send a pull request then if it hasn't already been dealt with. @SpiralBaka @dteviot

@dteviot
Copy link
Owner

dteviot commented Feb 23, 2024

@ImmortalDreamer

I'll say thank you very much. I don't know Japanese, so trying to do syosetu is something of a pain for me. I'll leave it to you.

@ImmortalDreamer
Copy link
Contributor

@dteviot @SpiralBaka So, I had a look at this last weekend and it was way more work than I thought, simply because the info is present on a different page. I'm going to try a different approach soon and see if that works.

@dteviot
Copy link
Owner

dteviot commented Mar 2, 2024

@ImmortalDreamer

Thanks for letting us know.

@ImmortalDreamer
Copy link
Contributor

@dteviot Took a while but #1247 solves the information page issue. Tested it on both ncode.syosetu.com and novel18.syosetu.com novels, works fine.
@SpiralBaka Please wait for dteviot to merge and provide the test version.

dteviot added a commit that referenced this issue Mar 12, 2024
Updated SyosetuParser.js to resolve issue #1210
@dteviot
Copy link
Owner

dteviot commented Mar 12, 2024

@SpiralBaka @ImmortalDreamer

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.

@dteviot
Copy link
Owner

dteviot commented Mar 12, 2024

@SpiralBaka @ImmortalDreamer

If you confirm this is good, I'll update the Google and Firefox stores.

@ImmortalDreamer
Copy link
Contributor

@dteviot Looks good to me.

@dteviot
Copy link
Owner

dteviot commented Mar 22, 2024

@ImmortalDreamer
Thank you for your hard work

@SpiralBaka

Updated version (0.0.0.158) has been submitted to Firefox store and is available now
Due to technical issues (i.e. I pressed the wrong button) updated version can't be submitted to Chrome store for an indefinite period.
Chrome might be available in 6 to 42 days.

@dteviot dteviot closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants